Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Github Action to Examine Terraform Scripts #275

Closed
wants to merge 4 commits into from
Closed

Create Github Action to Examine Terraform Scripts #275

wants to merge 4 commits into from

Conversation

backwind1233
Copy link
Contributor

@backwind1233 backwind1233 commented Apr 1, 2022 •
edited
Loading

  1. Create github action to examine terraform scripts.
  2. Fix ip resolve error: it should be ipv4 address but the result is ipv6 address.
  3. Add network_acls block for keyvault in terraform scripts.

Linked issue: #269

@backwind1233 backwind1233 mentioned this pull request Apr 1, 2022
Closed
@backwind1233 backwind1233 self-assigned this Apr 1, 2022
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Apr 1, 2022
@backwind1233 backwind1233 mentioned this pull request Apr 1, 2022
Closed
3 tasks
@backwind1233
Copy link
Contributor Author

Close this pr, the github action has strict rule of keyvault terraform scripts, the network_acls limit the ips, but the ip in local machine may change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@backwind1233 backwind1233

Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@backwind1233