feat: Implement hybrid search on BYOD endpoint. #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superhindupur
changed the title
superhindupur
force-pushed
the
implement-hybrid-search-on-byod
branch
from
e3ccb8b to
1c61ee9
Compare
|
Is this for #295? |
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Yes. |
Yes @ross-p-smith. I updated the PR description. |
superhindupur
changed the title
gaurarpit
reviewed
May 13, 2024
adamdougal
approved these changes
May 13, 2024
cecheta
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Before this change, the
/api/conversation/byodendpoint did not use hybrid search - it only used "simple" or "semantic" query types, based on whether semantic search was enabled.This PR changes the query types to
vector_simple_hybridandvector_simple_hybridrespectively.Fixes #295
Does this introduce a breaking change?
How to Test
Deploy CWYD.
Ingest a file and test whether chat works with and without semantic search enabled.