fix: deployment issue with stripe (closes #399) #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinedied
requested review from
anfibiacreativa and
manekinekko
as code owners
anfibiacreativa
previously approved these changes
Mar 2, 2024
|
FYI, a fix has alrady been merged to develop via https://github.com/Azure-Samples/contoso-real-estate/pull/416/files |
|
@manekinekko I've rebased the branch from develop, should be good now |
manekinekko
previously approved these changes
Mar 6, 2024
manekinekko
previously approved these changes
Mar 8, 2024
|
@sinedied can you please resolve conflicts and merge. Thanks! |
|
@sinedied I think you've accidentally pushed a chat-sample submodule. Could you please delete it? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to update a few packages, and the stripe api version.
To make sure this won't happen again, I renamed the
build:tsscript tobuildso it the stripe package will be built with the others on the CI.