Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples to 2020-05-01 version #82

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Update samples to 2020-05-01 version #82

merged 1 commit into from
Nov 18, 2020

Conversation

giakas
Copy link
Contributor

@giakas giakas commented Nov 13, 2020

Purpose

  • ...

Does this introduce a breaking change?

[x ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

ningl2
ningl2 reviewed Nov 17, 2020
View reviewed changes
ContentProtection/BasicPlayReady/pom.xml
<artifactId>azure-mgmt-media</artifactId>
<version>1.0.0-beta-4</version>
<version>1.0.0-beta</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [](start = 20, length = 1)

Why is this still beta? How is this version used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will follow up. but that will not affect this PR, so merging.

ningl2
ningl2 approved these changes Nov 17, 2020
View reviewed changes
Copy link

@ningl2 ningl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@giakas giakas merged commit 0b41daa into master Nov 18, 2020
@giakas giakas deleted the giakas/updateTo2020 branch November 18, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ningl2 ningl2 ningl2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giakas @ningl2