Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Databricks E2E] Sprint 5 improvements #1082

Merged
merged 56 commits into from
Feb 6, 2025

Conversation

elenaterenzi
Copy link
Contributor

@elenaterenzi elenaterenzi commented Feb 5, 2025

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes

Purpose

  • Merge work done in Sprint 5 to main

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Deploy repository
  • Validate that Synapse Pool is not resized when you re-deploy to the same resource group
  • CI/CD pipelines fail when something is wrong and are successful when no errors occur (previously they might succeed even with failures)
  • the Databricks cluster VM type is automatically selected with the least resources for the region
  • Test clean-up script to validate that all App registrations are being deleted
  • AzDO Service Connections to Azure are now created using workload identity and clean-up script correctly removes everything including the App Registration (SPN)
  • You now can choose to deploy 1, 2 (partial deployment) or 3 (full deployment) environments

Issues Closed or Referenced

ydaponte and others added 30 commits December 23, 2024 14:17
#988)

* automate region vm + dbx type cluster in the region

* Update e2e_samples/parking_sensors/scripts/configure_databricks.sh

Co-authored-by: Elena Terenzi <[email protected]>

* filtering photon support

---------

Co-authored-by: Elena Terenzi <[email protected]>
* fix breaking change from dbx cli output
* fix hyperlink check
Adding the Cleanup for federal credentials which follows a certain order:
Get the SP Objc ID of the Service Connection
Delete federated credentials from the SP Object ID
Delete the service connection
Service Connections are using the Workload Identity which comes from a configuration file.

The cleanup in case of re-start of this script also follows a peculiar order: 

Get SP object if according to the Service Connection
Get the federate credential according to the SP
Delete federated credentials
Delete the Service Connection
changing the docs with the required permission
rephrase the permissions needed for azdevops project
I adjust the order of the permissions
adding know issues how to delete federate credentials
identation was not correct
adding the following changes:
1) Function for cleanup
2)Function for sleep
3)Remove log file
Implement function for cleanup and function for sleep
Added cleanup_federate_credentials and wait_for_credentials used in the clean_up.sh and deploy_azdo_service_connection.sh
rename wait_for_cleanup to wait_for_process
renamed wait_for_cleanup to wait_for_process
typo:
comtain to contain fxed
added Elena's suggestion of rewrite

Co-authored-by: Elena Terenzi <[email protected]>
remove the log for SP
Clean up of the log
suppress update pipelines message
remove response from logging
changing the log for federate credentials removal
adding the SP in the log message
checking if the file exist before removal.
LiliamLeme and others added 24 commits January 14, 2025 15:08
adding -0 none to resolve conflict
…sor_v1_lilem

E2e/databricks/parkingsensor v1 lilem
…val (#1047)

* remove federated credentials only when needed

* fix typo
* remove SPN for AzDO service connection

* minor edits

* minor edits

* minor typo

* add readme change for manual deletion
* Deploy.sh will have the option to deploy as:
1) dev
2) Dev and Stage
3) Dev, Stage and Prod

Common.sh will heold the function for this changes
envtemplate the new environmnent variable for the
deployment options
deploy_azdo_pipelines.sh will deploy the release
pipeline if option 2 or 3 are choosen which
implies the deploy of t least 2 environmnents

* adjusting the readme according to the latest version in v1

* Seems this session was not veru well documented -
**Workaround - Manually Deleting Federated Credentials:**

* to* typo

* Update e2e_samples/parking_sensors/README.md

Co-authored-by: Copilot <[email protected]>

* Remove duplicate deployment instruction in README

fixing copilot fix

* Adding if for deploy.sh respect configuration in
the enviromnent variable

Initialize env variable in the init_environment

* adjust the readme for env. varaible configuration

* Clarify deployment options and environment variable usage

Adjusting explanations about env variable in the readme and envtemplate

* Update workaround for deleting Azure DevOps Service Connection

fixing conflict

* Refactor cleanup function to delete service principal

fix the conflict

---------

Co-authored-by: Copilot <[email protected]>
* Recreates the CI CD process diagrams in drawio
* Remove the ADF publish step from CI CD process diagrams
* Update the README.md to reflect the changes in the process sequence and diagram files

---------

Co-authored-by: Jose Perales <[email protected]>
* Fix devcontainer for wheel library builds
* env file required for devcontainer
* Update e2e_samples/parking_sensors/src/ddo_transform/.devcontainer/Dockerfile
* fix: release paths and cluster id

* fix: adding azdo file

* fix: removing unnecessary config

* update: readMe, optimize code flow

* update: upgrade DB CLI and fix release pipeline

* fix: pr comments
* Add PowerShell and Bash scripts for Synapse Pause/Resume

* Support Manual and Automated Synapse Pause PowerShell Script with Additional features

* Add README file for Synapse Pause script

* Add References section to Synapse Pause README file

* Add InstallModules parameter to pause_resume_synapse script for automatic module installation

* Enhance README and script usage documentation for pause_resume_synapse and improved logging for state transitions

* Update README_pause_resume_synapse to include example values for parameters

* Update README_pause_resume_synapse to provide specific examples for ResourceGroups parameter
@elenaterenzi elenaterenzi marked this pull request as ready for review February 6, 2025 14:01
@elenaterenzi elenaterenzi merged commit 4b42d3d into main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix py extension on adf pipeline definition
7 participants