Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric E2E Sample] Minor bug fixes #953

Conversation

promisinganuj
Copy link
Contributor

Type of PR

  • Code changes

Purpose

This PR is to fix minor issues, primarily in the deployment script of Fabric E2E sample. It's addressing the following issues:

Does this introduce a breaking change? If yes, details on what can break

Yes, it updates the main deployment script.

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Deploy the sample as per the README.md instructions.

Issues Closed or Referenced

@promisinganuj promisinganuj self-assigned this Dec 13, 2024
@promisinganuj promisinganuj added e2e: fabric Related with E2E Fabric Sample python Pull requests that update Python code labels Dec 13, 2024
@promisinganuj promisinganuj changed the base branch from main to feat/e2e-fabric-dataops-sample-v0-2 December 17, 2024 06:06
@naga-nandyala naga-nandyala self-requested a review December 17, 2024 23:33
@promisinganuj promisinganuj merged commit bfe1d0c into feat/e2e-fabric-dataops-sample-v0-2 Dec 18, 2024
3 checks passed
@promisinganuj promisinganuj deleted the promisinganuj/minor-fixes-in-deployment-script branch December 18, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e: fabric Related with E2E Fabric Sample python Pull requests that update Python code
Projects
None yet
2 participants