This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Upd network resource name and cli outputs #53
Open
athinanthny
wants to merge
33
commits into
Azure-Samples:2018-09-01-preview
Choose a base branch
from
athinanthny:patch-1
base: 2018-09-01-preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upd network resource name and cli outputs #53
athinanthny
wants to merge
33
commits into
Azure-Samples:2018-09-01-preview
from
athinanthny:patch-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be appended to the image name.
…store/linux Add linux sfmesh counter sf block store app
…Sample-2018-09-01-preview Add SF Volume Disk Counter Sample and template
…/service-fabric-mesh into 2018-09-01-preview
updated linux templates for visualobjects
* added windows version * fixed network and renamed * renamed network
* Move all updated templates to using 10.0.0.0/24 subnet. * Add default location value for all templates set to the resource group's location.
* added the stateful one * added the stateful one * fix the network address prefix * use secrets
…n the counter directory.
* Update mesh_rp.base.linux.json * Update mesh_rp.scaleout.linux.json * Update mesh_rp.upgrade.linux.json * Update mesh_rp.base.linux.json * Update mesh_rp.scaleout.linux.json * Update mesh_rp.upgrade.linux.json
…mples#48) * Flush data to disk. * Remove duplicate code packages in counterSFVolumeDisk
Copy doc from MicrosoftDocs/azure-docs to Azure-Samples
1) Updated reference to counterAppNetwork to counterNetwork for network resource name 2) expected output for az mesh deployment create and how to find out public IP address for counter app.
mattrowmsft
approved these changes
Nov 28, 2018
dkkapur
force-pushed
the
2018-09-01-preview
branch
from
December 4, 2018 23:54
db355e8
to
e04d008
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
updated command outputs to reflect expected functionality and resource names.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information