Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated bicep api versions #651

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Updated bicep api versions #651

merged 7 commits into from
Oct 25, 2023

Conversation

oliverlabs
Copy link
Contributor

@oliverlabs oliverlabs commented Aug 30, 2023 •
edited by pjlewisuk
Loading

PR Summary

Updated bicep API versions using the bruh tool.

Here's a list of changes:

acragentpool.bicep:
  + Updated Microsoft.ContainerRegistry/registries to version 2022-12-01

aksagentpool.bicep:
  + Updated Microsoft.ContainerService/managedClusters to version 2023-05-01

aksmetricalerts.bicep:
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/metricAlerts to version 2018-03-01
  + Updated Microsoft.Insights/scheduledQueryRules to version 2022-06-15

aksnetcontrib.bicep:
  + Updated Microsoft.Network/virtualNetworks to version 2023-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01

appgw.bicep:
  + Updated Microsoft.Network/publicIPAddresses to version 2023-04-01
  + Updated Microsoft.Network/applicationGateways to version 2023-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01

automationrunbook/aksRbac.bicep:
  + Updated Microsoft.ContainerService/managedClusters to version 2023-05-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01

automationrunbook/automation.bicep:
  + Updated Microsoft.Automation/automationAccounts to version 2022-08-08
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01

calcAzFwIp.bicep:

dnsZone.bicep:
  + Updated Microsoft.Network/dnsZones to version 2018-05-01
  + Updated Microsoft.Network/privateDnsZones to version 2020-06-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01

dnsZoneRbac.bicep:

firewall.bicep:
  + Updated Microsoft.Network/publicIPAddresses to version 2023-04-01
  + Updated Microsoft.Network/publicIPAddresses to version 2023-04-01
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01
  + Updated Microsoft.Network/azureFirewalls to version 2023-04-01
  + Updated Microsoft.Network/firewallPolicies to version 2023-04-01

keyvault.bicep:
  + Updated Microsoft.KeyVault/vaults to version 2022-07-01
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01

keyvaultkey.bicep:
  + Updated Microsoft.KeyVault/vaults to version 2022-07-01

keyvaultrbac.bicep:
  + Updated Microsoft.KeyVault/vaults to version 2022-07-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01

main.bicep:
  + Updated Microsoft.ManagedIdentity/userAssignedIdentities to version 2023-01-31
  + Updated Microsoft.ManagedIdentity/userAssignedIdentities to version 2023-01-31
  + Updated Microsoft.KeyVault/vaults to version 2022-07-01
  + Updated Microsoft.ContainerRegistry/registries to version 2022-12-01
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.ManagedIdentity/userAssignedIdentities to version 2023-01-31
  + Updated Microsoft.Network/publicIPAddresses to version 2023-04-01
  + Updated Microsoft.Network/applicationGateways to version 2023-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01
  + Updated Microsoft.ContainerService/managedClusters to version 2023-05-01
  + Updated Microsoft.Authorization/policyAssignments to version 2022-06-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.KubernetesConfiguration/extensions to version 2022-11-01
  + Updated Microsoft.KubernetesConfiguration/extensions to version 2022-11-01
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01
  + Updated Microsoft.Insights/dataCollectionRules to version 2021-04-01
  + Updated Microsoft.Insights/dataCollectionRuleAssociations to version 2021-04-01
  + Updated Microsoft.OperationalInsights/workspaces to version 2022-10-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.EventGrid/systemTopics to version 2022-06-15
  + Updated Microsoft.Insights/diagnosticSettings to version 2016-09-01
  + Updated Microsoft.Resources/deployments to version 2022-09-01

network.bicep:
  + Updated Microsoft.Network/routeTables to version 2023-04-01
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01
  + Updated Microsoft.Network/virtualNetworks to version 2023-04-01
  + Updated Microsoft.Network/privateEndpoints to version 2023-04-01
  + Updated Microsoft.Network/privateDnsZones to version 2020-06-01
  + Updated Microsoft.Network/privateEndpoints to version 2023-04-01
  + Updated Microsoft.Network/privateDnsZones to version 2020-06-01
  + Updated Microsoft.Network/publicIPAddresses to version 2023-04-01
  + Updated Microsoft.Network/bastionHosts to version 2023-04-01
  + Updated Microsoft.OperationalInsights/workspaces to version 2022-10-01
  + Updated Microsoft.Storage/storageAccounts to version 2022-09-01
  + Updated Microsoft.Network/publicIPAddresses to version 2023-04-01
  + Updated Microsoft.Network/natGateways to version 2023-04-01

networksubnetrbac.bicep:
  + Updated Microsoft.Authorization/roleAssignments to version 2022-04-01

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby added the test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge label Sep 18, 2023
pjlewisuk
pjlewisuk requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Oliver,

The changes look good, although I'm still seeing a bunch of these API warnings when I try to deploy a cluster from your branch:

/workspaces/AKS-Construction/bicep/acragentpool.bicep(5,54) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.ContainerRegistry/registries'. '2023-01-01-preview' is a preview version and there is a more recent non-preview version available. Acceptable versions: 2023-08-01-preview, 2023-07-01, 2022-12-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/keyvault.bicep(58,57) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/aksagentpool.bicep(54,58) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.ContainerService/managedClusters'. '2023-05-02-preview' is a preview version and there is a more recent non-preview version available. Acceptable versions: 2023-07-02-preview, 2023-07-01, 2023-06-01, 2023-05-01, 2023-04-01, 2023-03-01, 2023-02-01, 2023-01-01, 2022-11-01, 2022-09-01, 2022-07-01, 2022-06-01, 2022-04-01, 2022-03-01, 2022-02-01, 2022-01-01, 2021-10-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/firewall.bicep(54,57) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/network.bicep(282,90) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups'. '2021-08-01' is 779 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2023-05-01, 2023-04-01, 2023-02-01, 2022-11-01, 2022-09-01, 2022-07-01, 2022-05-01, 2022-01-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/network.bicep(340,90) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Network/privateEndpoints/privateDnsZoneGroups'. '2021-08-01' is 779 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2023-05-01, 2023-04-01, 2023-02-01, 2022-11-01, 2022-09-01, 2022-07-01, 2022-05-01, 2022-01-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/network.bicep(409,9) : Warning BCP334: The provided value can have a length as small as 0 and may be too short to assign to a target with a configured minimum length of 3.
/workspaces/AKS-Construction/bicep/nsg.bicep(246,58) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(413,54) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.ContainerRegistry/registries'. '2023-01-01-preview' is a preview version and there is a more recent non-preview version available. Acceptable versions: 2023-08-01-preview, 2023-07-01, 2022-12-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(452,58) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(815,60) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(1339,58) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.ContainerService/managedClusters'. '2023-05-02-preview' is a preview version and there is a more recent non-preview version available. Acceptable versions: 2023-07-02-preview, 2023-07-01, 2023-06-01, 2023-05-01, 2023-04-01, 2023-03-01, 2023-02-01, 2023-01-01, 2022-11-01, 2022-09-01, 2022-07-01, 2022-06-01, 2022-04-01, 2022-03-01, 2022-02-01, 2022-01-01, 2021-10-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(1535,58) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(1553,57) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/dataCollectionRules'. '2021-09-01-preview' is 748 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2022-06-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(1636,73) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/dataCollectionRuleAssociations'. '2021-09-01-preview' is 748 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2022-06-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/workspaces/AKS-Construction/bicep/main.bicep(1756,64) : Warning use-recent-api-versions: Use more recent API version for 'Microsoft.Insights/diagnosticSettings'. '2021-05-01-preview' is 871 days old, should be no more than 730 days old, or the most recent. Acceptable versions: 2016-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]

Are there updated API versions for these APIs too?

@pjlewisuk
Copy link
Contributor

@oliverlabs Any chance to look at this again?

pjlewisuk
pjlewisuk approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjlewisuk pjlewisuk merged commit afc8715 into Azure:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjlewisuk pjlewisuk pjlewisuk approved these changes

Assignees
No one assigned
Labels
test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverlabs @pjlewisuk @Gordonby