-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update github workflow for Deploy Enterprise Landing Zone Hub & Spoke Infrastructure #160
Open
iamaliyousefi
wants to merge
82
commits into
Azure:main
Choose a base branch
from
iamaliyousefi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debugging
azure/login@v2
azure/cli@v2
using client_id, etc. instead of cred
azureBastionSubnetAddressPrefix, azureBastionSubnetName, azureFirewallManagementSubnetAddressPrefix, azureFirewallManagementSubnetName
Update route table to fix the error below: ERROR: (ApplicationGatewaySubnetUserDefinedRouteNotAllowed) Route Table /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/routeTables/AppGWSubnet-RT is associated to subnet /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/virtualNetworks/VNet-SPOKE/subnets/AppGWSubnet, which contains V2 SKU Application Gateway /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/applicationGateways/APPGW. Route /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/routeTables/AppGWSubnet-RT/routes/vm-to-internet in the route table has AddressPrefix '0.0.0.0/0'. For routes associated to subnet containing Application Gateway V2, please ensure '0.0.0.0/0' uses NextHopType as 'Internet'.
update route table for appGW subnet for fix the error below: // to fix ERROR: (ApplicationGatewaySubnetUserDefinedRouteNotAllowed) Route Table /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/routeTables/AppGWSubnet-RT is associated to subnet /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/virtualNetworks/VNet-SPOKE/subnets/AppGWSubnet, which contains V2 SKU Application Gateway /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/applicationGateways/APPGW. Route /subscriptions/***/resourceGroups/ESLZ-SPOKE-RG/providers/Microsoft.Network/routeTables/AppGWSubnet-RT/routes/vm-to-internet in the route table has AddressPrefix '0.0.0.0/0'. For routes associated to subnet containing Application Gateway V2, please ensure '0.0.0.0/0' uses NextHopType as 'Internet'.
ERROR: {"code": "InvalidTemplate", "message": "Deployment template validation failed: 'The following parameters were supplied, but do not correspond to any parameters defined in the template: 'appGatewayName'.
to fix error: 'The provided value for the template parameter 'autoScalerProfileMaxGracefulTerminationSec' is not valid. Expected a value of type 'Integer', but received a value of type 'String'.
[{"code":"InvalidTemplate","message":"Deployment template validation failed: 'The provided value for the template parameter 'autoScalerProfileBalanceSimilarNodeGroups' is not valid. Expected a value of type 'Boolean', but received a value of type 'String'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update github workflow for Deploy Enterprise Landing Zone Hub & Spoke Infrastructure