backend: Fix nil pointer dereference

Don't count on OperationID being set in OperationDocuments. Implicit async operations will not have this field set. Get the subscription ID from ExternalID instead.
Azure · Dec 4, 2024 · d76b6ac · d76b6ac
1 parent 353d9e9
commit d76b6ac
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/backend/operations_scanner.go b/backend/operations_scanner.go
@@ -165,7 +165,7 @@ func (s *OperationsScanner) pollClusterOperation(ctx context.Context, logger *sl
 	if err != nil {
 		var ocmError *ocmerrors.Error
 		if errors.As(err, &ocmError) && ocmError.Status() == http.StatusNotFound && doc.Request == database.OperationRequestDelete {
-			err = s.withSubscriptionLock(ctx, logger, doc.OperationID.SubscriptionID, func(ctx context.Context) error {
+			err = s.withSubscriptionLock(ctx, logger, doc.ExternalID.SubscriptionID, func(ctx context.Context) error {
 				return s.deleteOperationCompleted(ctx, logger, doc)
 			})
 			if err == nil {
@@ -180,7 +180,7 @@ func (s *OperationsScanner) pollClusterOperation(ctx context.Context, logger *sl
 		logger.Warn(err.Error())
 		err = nil
 	} else {
-		err = s.withSubscriptionLock(ctx, logger, doc.OperationID.SubscriptionID, func(ctx context.Context) error {
+		err = s.withSubscriptionLock(ctx, logger, doc.ExternalID.SubscriptionID, func(ctx context.Context) error {
 			return s.updateOperationStatus(ctx, logger, doc, opStatus, opError)
 		})
 	}