Add unit tests for "validate" struct tags #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2024 13:21
This results in more detail in the validation errors in case entire subsections of the resource specification are missing. For example, instead of just reporting a missing "version" "Missing required field 'properties.spec.version'" call out the required fields within "version" "Missing required field 'properties.spec.version.id'" "Missing required field 'properties.spec.version.channelGroup'"
Read-only fields don't require user input validation.
Node pool validation tags are lagging behind the API spec.
Specifically for OutboundType which is always "loadBalancer". ... (must be loadBalancer) instead of ... (must be one of: loadBalancer)
This is important to have anyway, but it also provides a way to try new validation tags without requiring a fully deployed test environment.
mbarnes
force-pushed
the
validation-tests
branch
from
a504371 to
1dfd984
Compare
mjlshen
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds unit tests for the various "validate" struct tags in use, which leverage the package validator module. I also added some tweaks and corrections to existing "validate" tags based on this testing.
Another benefit to this test framework is it allows us to easily try out new validators, or combinations of validators, without having to stand up a full test environment.
Jira: none, was inspired by a Slack thread
Link to demo recording:
Special notes for your reviewer