database: Fix error code check in LockClient.TryAcquireLock #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
force-pushed
the
lock-client-fix-error-code
branch
from
96b94e3 to
15ced81
Compare
When attempting to create an item with an ID that already exists, Cosmos responds with 409 Conflict not 412 Precondition Failed.
mbarnes
force-pushed
the
lock-client-fix-error-code
branch
from
15ced81 to
fd43c50
Compare
mjlshen
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Already found a boo boo in
database.LockClient...When attempting to create an item with an ID that already exists, Cosmos responds with 409 Conflict not 412 Precondition Failed.
Jira: Additional testing of ARO-10822 - Add concurrency controls around Cosmos DB
Link to demo recording:
Special notes for your reviewer