WIP: maestro azure postgres entra auth #900
Open
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
requested review from
bennerv,
janboll,
weinong,
whober0521,
tony-schndr,
jmelis,
jonathan34c,
niontive,
nwnt,
SudoBrendan,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
force-pushed
the
maestro-entra
branch
from
238652c
to
e454cd7
Compare
janboll
reviewed
Nov 27, 2024
Comment on lines
+41
to
44
| 'GRANT ALL ON SCHEMA public TO "${newUserName}";' | ||
| 'GRANT USAGE ON SCHEMA public TO "${newUserName}";' | ||
| 'GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA public TO "${newUserName}";' | ||
| ] |
There was a problem hiding this comment.
no that was me trying to figure out what permissions are required for PG 15+ auth to work. i can most likely clean up the stuff before \c DB but i need to test if that breaks something for CS which is still on PG 12 right now
janboll
reviewed
Nov 27, 2024
| @@ -21,5 +22,7 @@ deploy: | |||
| --set image.base=${IMAGE_BASE} \ | |||
| --set image.tag=${IMAGE_TAG} \ | |||
| --set database.containerizedDb=${USE_CONTAINERIZED_DB} \ | |||
| --set database.ssl='${USE_DATABASE_SSL}' | |||
| --set database.ssl='${USE_DATABASE_SSL}' \ | |||
| $(if $(filter false,$(USE_CONTAINERIZED_DB)),--set database.host=$${DATABASE_HOST}) \ | |||
There was a problem hiding this comment.
Is this some fallback for other environments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
leverage entra auth for postgres access
befor merging:
Jira: https://issues.redhat.com/browse/ARO-8831
Link to demo recording:
Special notes for your reviewer