convert cs deployment to helm chart #922
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-schndr
force-pushed
the
cluster-service-helm-chart
branch
2 times, most recently
from
090ef00
to
bc89279
Compare
|
Please rebase pull request. |
machi1990
reviewed
Dec 4, 2024
| config.json: | | ||
| { | ||
| "cloudEnvironment": "AzurePublicCloud", | ||
| "managedIdentitiesDataPlaneAudienceResource": "https://dummy.org", |
There was a problem hiding this comment.
this should also be parameterised - see ARO-12801
tony-schndr
force-pushed
the
cluster-service-helm-chart
branch
from
bc89279
to
6c9d7e3
Compare
tony-schndr
force-pushed
the
cluster-service-helm-chart
branch
from
6c9d7e3
to
a7643b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes https://issues.redhat.com/browse/ARO-11949
Jira:
Link to demo recording:
Special notes for your reviewer