chore: make linux e2e tests run for the VHD they are built for. #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
zachary-bailey
as code owners
|
One thing is concerning me. We're running a bunch of steps to prepare a test environment. Create an RG, create a cluster etc. Now we're going to attempt the same action concurrently x20. (There is also can be concurrent pipeline execution) It may produce some subtle and flaky concurrency-related bugs. It also increases amount of ARM-API calls and makes it more likely to get the subscription throttled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/chore
What this PR does / why we need it:
This PR changes the Linux VHD build pipeline so that the e2e tests run for each VHD, and only the e2e tests for that VHD are run. It removes duplication between the PR VHDs we build (and those e2e tests) and makes the template a bit easier to read.
Note that at this time, the e2e test filtering is not working. I'll work on that when I have some headspace.
Screen snapshot of new pipeline structure. Note that this is taken from the PR checkin pipeline, so we are disabling most VHD builds and tests - only building and testing 3 VHDs. This is easily configurable.
Requirements:
Special notes for your reviewer:
Release note: