Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop sr0 log lines from aks-log-collector.sh #5457

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

phealy
Copy link
Collaborator

@phealy phealy commented Dec 19, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The aks-log-collector.sh script runs blkid to generate a listing of the available block devices in the system. Azure uses a virtual CD-ROM device to attach the initial provisioning data for the VM, but ejects the "CD" after it's been read by cloud-init. This means that when blkid runs and tries to see what's in the virtual CD-ROM drive, the kernel reports a series of errors to the kernel log and syslog:

[164138.178951] hv_storvsc f8b3781a-1e82-4818-a1c3-63d806ec15bb: tag#90 cmd 0x28 status: scsi 0x2 srb 0x84 hv 0xc0000001
[164138.178958] sr 0:0:0:2: [sr0] tag#90 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_OK cmd_age=0s
[164138.178961] sr 0:0:0:2: [sr0] tag#90 Sense Key : Not Ready [current]
[164138.178963] sr 0:0:0:2: [sr0] tag#90 Add. Sense: Medium not present - tray open
[164138.178965] sr 0:0:0:2: [sr0] tag#90 CDB: Read(10) 28 00 00 00 00 02 00 00 02 00
[164138.178967] blk_update_request: I/O error, dev sr0, sector 8 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[164138.185025] Buffer I/O error on dev sr0, logical block 1, async page read

These errors are repeated hourly on all VMs to no purpose except for consuming disk and log space. This PR fixes this by modifying blkid to run on all block devices that do not match the sr* pattern, which excludes the virtual CD-ROM device.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

AKS's log collection script will no longer trigger non-relevant errors about `/dev/sr0` to the kernel/system log every hour.

@djsly
Copy link
Contributor

djsly commented Dec 20, 2024

does the release note section actually help with the official AKS release note ?

Copy link
Collaborator

@cameronmeissner cameronmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this will be a big improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants