bug: add env var CONTAINERD_CONFIG_NO_GPU_CONTENT back for scriptless #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devinwong
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
r2k1
approved these changes
Jan 28, 2025
Devinwong
force-pushed
the
devinwon/containerd_config
branch
from
abf21d3 to
990d6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
bug: add env var CONTAINERD_CONFIG_NO_GPU_CONTENT back for scriptless. Otherwise No_GPU e2e test will fail.
Tested pass in a new ab e2e test
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: