Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting tolerations, nodeSelector, and affinity during helm install #8

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Support setting tolerations, nodeSelector, and affinity during helm install #8

merged 4 commits into from
Jan 31, 2024

Conversation

linglingye001
Copy link
Contributor

No description provided.

RichardChen820
RichardChen820 reviewed Jan 30, 2024
View reviewed changes
deploy/parameter/helm-values.yaml
memory: 128Mi
requests:
cpu: 10m
cpu: 20m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked when the controller is running without any provider yaml being deployed, how many resource it take?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

RichardChen820
RichardChen820 reviewed Jan 30, 2024
View reviewed changes
deploy/templates/autoscaling.yaml Outdated
apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: az-appconfig-k8s-provider-hpa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the full name variable

RichardChen820
RichardChen820 reviewed Jan 30, 2024
View reviewed changes
deploy/parameter/helm-values.yaml Outdated
@@ -41,18 +41,31 @@ securityContext:

resources:
limits:
cpu: 500m
cpu: 100m
memory: 128Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems double the request memory is too conservative. How about using 256Mi as a limit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@linglingye001 linglingye001 changed the base branch from main to release/v1.1 January 31, 2024 04:55
@linglingye001 linglingye001 merged commit 5716345 into release/v1.1 Jan 31, 2024
4 checks passed
@linglingye001 linglingye001 deleted the user/linglingye/podSchedule branch January 31, 2024 08:43
linglingye001 added a commit that referenced this pull request Feb 2, 2024
@linglingye001
Merge release/v1.1 to main (#12)
69a37ba 
* Support setting tolerations, nodeSelector, and affinity during helm install (#8)

* add affinity/nodeSelector/tolerations in helm chart deployment file

* add hpa

* configure hpa when autoscaling is true

* resolve comments

* Bump up version to 1.1.1 (#11)

* Bump up version to 1.1.1

* update ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardChen820 RichardChen820 RichardChen820 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linglingye001 @RichardChen820