Refresh enhancement #85
Open
+105
−746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,126 +160,6 @@ var _ = Describe("AppConfiguationProvider processor", func() { | |||
| }]).Should(Equal(&newFakeEtag2)) | |||
| Expect(processor.ReconciliationState.NextKeyValueRefreshReconcileTime).Should(Equal(expectedNextKeyValueRefreshReconcileTime)) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Why we remove this test?
| _ = json.Unmarshal([]byte(existingConfigMap.Data[dataOptions.Key]), &existingSettings) | ||
| _ = json.Unmarshal([]byte(latestConfigMapSettings[dataOptions.Key]), &latestSettings) | ||
|
|
||
| return !reflect.DeepEqual(existingSettings, latestSettings) | ||
| } | ||
|
|
||
| return false |
There was a problem hiding this comment.
How about return true by default?
There was a problem hiding this comment.
Is there any scenario that will use the default value? The check of configmap data will be returned before line354.
linglingye001
force-pushed
the
linglingye/fixRefresh
branch
from
3f451eb to
d4931fd
Compare
internal/controller/utils.go
Outdated
| return !reflect.DeepEqual(processor.Settings.SecretSettings[secretName].Data, existingK8sSecrets[secretName].Data) | ||
| } | ||
|
|
||
| func shouldCreateOrUpdateConfigMap(existingConfigMap *corev1.ConfigMap, dataOptions *acpv1.ConfigMapDataOptions, latestConfigMapSettings map[string]string) bool { |
There was a problem hiding this comment.
could you change the argument order to (existingConfigMap, latestConfigMapSettings, dataOptions ) for more readable.
RichardChen820
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.