-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuoteOfTheDay examples for experimentation with feature managment #909
base: main
Are you sure you want to change the base?
Conversation
examples/README.md
Outdated
|
||
This example is an ASP .NET Core app that demonstrates how to use the [Microsoft .NET Feature Management library](https://www.nuget.org/packages/Microsoft.FeatureManagement/) to do experimentation with feature flags. | ||
|
||
### [QuoteOfTheDaySimulator](./Experimentation/Dotnet/QuoteOfTheDaySimulator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should include the simulator. The simulator is for our own demo'ing and testing.
examples/README.md
Outdated
@@ -34,6 +34,14 @@ This ASP.NET web application is a .NET Framework MVC 5 app. It leverages the [co | |||
|
|||
This ASP.NET web application is a .NET Framework Web Forms app. It demonstrates how to leverage the App Configuration [.NET Standard provider library](https://www.nuget.org/packages/Microsoft.Extensions.Configuration.AzureAppConfiguration/) to achieve dynamic configuration and control feature launches with feature flags. The same technique applies to .NET Framework MVC apps. | |||
|
|||
### [QuoteOfTheDayQuickStart](./Experimentation/Dotnet/QuoteOfTheDayQuickStart) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickstart is something we use in documentation (actually, we are planning to make it a tutorial). Please don't include it in the folder name.
The examples are organized by languages, not by topics today. The QuickStart folder is a special case for quickstarts from the portal. I think we should put this one under examples/DotNetCore/QuoteOfTheDay. We will use readme/document to explain this sample is related to telemetry and experimentation scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Somehow GH treats this file as binary. It doesn't allow me to add inline comments.)
Instead of sharing the simulator, I think we can share AppInsights queries like below. It will be helpful for users to see their results from App Insights.
https://github.com/zhenlan/QuoteOfTheDay?tab=readme-ov-file#review-telemetry-in-application-insights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need an example image? I didn't add one yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required, but I think it will be nice to have one.
No description provided.