Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds release notes for v4.0.0 #974

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Adds release notes for v4.0.0 #974

wants to merge 9 commits into from

Conversation

rossgrambo
Copy link
Member

No description provided.

@rossgrambo
Copy link
Member Author

How do we want to handle release notes on Microsoft.Featuremanagement.Telemetry.ApplicationInsights.AspNetCore (The deprecated package) ?

@zhenlan
Copy link
Contributor

zhenlan commented Sep 28, 2024

How do we want to handle release notes on Microsoft.Featuremanagement.Telemetry.ApplicationInsights.AspNetCore (The deprecated package) ?

How about updating its release notes one more time with a note saying this package has been deprecated and its functionalities have been moved to the xxxxx package?

@rossgrambo
Copy link
Member Author

Resolved all comments

@zhenlan zhenlan mentioned this pull request Oct 3, 2024
Merged
jimmyca15
jimmyca15 reviewed Oct 8, 2024
View reviewed changes
releaseNotes/Microsoft.Featuremanagement.Telemetry.ApplicationInsights.md Outdated
.AddApplicationInsightsTelemetry();
```

For more details on Application Insights Publishing, see [here](https://learn.microsoft.com/en-us/azure/azure-app-configuration/feature-management-dotnet-reference#application-insights-telemetry-publisher)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this link work for you consistently. It seemed to work for me once then break when I viewed it again as if it depended upon my previous tab state on the page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought it was just me having that problem... It always a problem even if you include the ?pivots=preview-version. I suspect the problem will go away once the pivots are gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyca15 jimmyca15 jimmyca15 left review comments

@zhenlan zhenlan zhenlan approved these changes

@zhiyuanliang-ms zhiyuanliang-ms Awaiting requested review from zhiyuanliang-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rossgrambo @zhenlan @jimmyca15