Refactor Push-PipelinesToList to handle null dependencies
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt.Ver2.ps1` to improve pipeline dependency handling. If a dependency is null, display a warning message. Otherwise, recursively call `Push-PipelinesToList` with the dependent pipeline.
|
@soma-ms Could you take a look at this pull request? |
|
The ADF product team just fixed the validation in the Data Factory, so now the execute pipelines activities that have no invoked pipeline should show up in the validate step during development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
Push-PipelinesToListfunction inPrePostDeploymentScript.Ver2.ps1to improve pipeline dependency handling.If a dependency is null, display a warning message identifying which pipeline and activity should be modified. Before the fix, the deployment pipeline would fail without giving any good error message.
Cases where dependency is null -> When one has an execute pipeline in the ADF, that references a pipeline that has been deleted, the activity is set to null. At the moment this does not show up as an error in the 'Validate' step in ADF (as I would expect it would)
Alternative fix: consider throwing an error with the same message, instead of just writing a warning ?
Resolves #679, resolves #678, resolves #675, resolves #431