Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: disable non-reliability recommendations #545

Merged
merged 2 commits into from
Dec 5, 2024
Merged

docs: disable non-reliability recommendations #545

merged 2 commits into from
Dec 5, 2024

Conversation

ejhenry
Copy link
Contributor

@ejhenry ejhenry commented Dec 2, 2024 •
edited
Loading

Overview/Summary

Disable non-reliability related recommendations for Redis, Event Grid, and App Services

Related Issues/Work Items

AB#37558

Breaking Changes

  1. None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ejhenry ejhenry requested a review from a team as a code owner December 2, 2024 22:58
@ejhenry ejhenry added the Area: Resource Guidance 📝 Improvements or additions to documentation label Dec 2, 2024
oZakari
oZakari approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rodrigosantosms
rodrigosantosms approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@rodrigosantosms rodrigosantosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@ejhenry ejhenry merged commit 6acccaa into Azure:main Dec 5, 2024
7 of 8 checks passed
@ejhenry ejhenry deleted the apps-updates branch December 5, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigosantosms rodrigosantosms rodrigosantosms approved these changes

@oZakari oZakari oZakari approved these changes

Assignees
No one assigned
Labels
Area: Resource Guidance 📝 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejhenry @rodrigosantosms @oZakari