Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

AKS-23 Nodepool subnet size needs to accommodate maximum auto-scale settings #388

Merged
merged 16 commits into from
Mar 28, 2024

Conversation

dminkovski
Copy link
Contributor

Overview/Summary

This Pull Request introduces an Azure Resource Graph (ARG) query that identifies AKS node pools with auto-scaling enabled and checks if the associated subnet's size can accommodate the configured max-nodes setting. This enhancement helps in proactively identifying misconfigurations that could prevent AKS clusters from scaling as intended.

Related Issues/Work Items

  • APRL - AKS-23: Nodepool subnet size needs to accommodate maximum auto-scale settings
  • 29853 - Apps - AKS - Subnet sized for autoscale max

This PR adds

  1. A query to check if the subnet size is sufficient for the auto-scaling max-nodes setting in AKS node pools.
  2. Improves visibility into potential AKS scaling issues due to subnet size limitations.
  3. Facilitates proactive network planning and configuration for AKS clusters.

Breaking Changes

  1. None expected. The query addition is non-intrusive and does not modify existing infrastructure or settings.

…ools with a subnetmask that does not match autoscale configured max-nodes
@dminkovski dminkovski requested a review from a team as a code owner March 22, 2024 15:18
@dminkovski dminkovski marked this pull request as draft March 22, 2024 15:20
Changed param labels and corrected spelling mistakes.
@Dost2010
Copy link
Contributor

Dost2010 commented Mar 24, 2024

Hello @dminkovski ,
Thank you for contributing. Can you please add id column in ARG query. For mor information please refer to guide here

@dminkovski dminkovski marked this pull request as ready for review March 25, 2024 14:32
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @dminkovski! Please include a screenshot of the successful testing of the query in the PR. Please also update the summary table on the _index.md page for AKS to indicate an ARG query is available for AKS-23.

@dminkovski
Copy link
Contributor Author

Testing Setup:
$LOCATION="westeurope"
$RESOURCE_GROUP="aks-23-rg"

  1. az network vnet create --name MyVnet --resource-group $RESOURCE_GROUP --address-prefix 10.0.0.0/16 --location $LOCATION
  2. az network vnet subnet create --name MySmallSubnet --resource-group $RESOURCE_GROUP --vnet-name MyVnet --address-prefix 10.0.0.0/29
  3. az aks create --resource-group $RESOURCE_GROUP --name MyAKSCluster --node-count 1 --enable-cluster-autoscaler --min-count 1 --max-count 10 --network-plugin kubenet --vnet-subnet-id /path/to/MySmallSubnet --service-cidr 10.0.1.0/24 --dns-service-ip 10.0.1.10 --pod-cidr 10.0.2.0/24

Test:

image

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari requested a review from a team March 27, 2024 16:56
@oZakari oZakari added the Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. label Mar 27, 2024
@ejhenry ejhenry added Needs: Author Feedback and removed Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. labels Mar 27, 2024
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry merged commit 4983fa8 into Azure:main Mar 28, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants