Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Update VMSS Main and VMSS 10 KQL #408

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Update VMSS Main and VMSS 10 KQL #408

merged 9 commits into from
Apr 2, 2024

Conversation

jimays-avila
Copy link
Contributor

@jimays-avila jimays-avila commented Mar 27, 2024

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

Related Issues/Work Items

No related work items. Changes based on engineering team recommendations. currently verifying APRL recommendations and updating based on the set recommendations.

This PR fixes/adds/changes/removes

  1. Updated VMSS main to set VMSS 10 KQL to no
  2. Removed VMSS 10 KQL based on recommendations.
  3. Updated impact for AFD-7 in main md file from "medium" to "High" based on recommendations from ARPL feedback leads.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jimays-avila jimays-avila requested a review from a team as a code owner March 27, 2024 18:57
@ejhenry
Copy link
Contributor

ejhenry commented Mar 27, 2024

@jimays-avila please resolve the merge conflicts. Thanks.

@ejhenry ejhenry added Area: Service Guidance Improvements or additions to documentation Needs: Author Feedback labels Mar 27, 2024
@jimays-avila
Copy link
Contributor Author

@jimays-avila please resolve the merge conflicts. Thanks.

@ejhenry I have resolved the conflict.

@jimays-avila jimays-avila requested a review from a team as a code owner March 29, 2024 13:35
@ejhenry ejhenry added the Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team label Mar 29, 2024
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maheshbenke maheshbenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimays-avila . Looks Good.

@maheshbenke maheshbenke added Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team. and removed Needs: Attention from aprl-networking 👋 Needs attention from aprl-networking GitHub team labels Apr 1, 2024
@oZakari oZakari merged commit ffbeed3 into Azure:main Apr 2, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Service Guidance Improvements or additions to documentation Needs: Attention from aprl-admins 👋 Needs attention from aprl-admins GitHub team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants