Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add devcontainer #1118

Merged
merged 17 commits into from
Oct 10, 2024
Merged

feat: add devcontainer #1118

merged 17 commits into from
Oct 10, 2024

Conversation

ReneHezser
Copy link
Contributor

Overview/Summary

With a devcontainer the hugo static website can be built in a local docker container instead of installing the required tooling on the client.

This PR fixes/adds/changes/removes

Closes #1117

Breaking Changes

none

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@ReneHezser ReneHezser requested a review from a team as a code owner June 19, 2024 11:03
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 19, 2024
@ReneHezser ReneHezser changed the title [feat] add devcontainer feat: add devcontainer Jun 19, 2024
@matebarabas matebarabas added Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: Documentation 📄 Improvements or additions to documentation and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 19, 2024
@ReneHezser ReneHezser closed this Jun 20, 2024
@ReneHezser ReneHezser reopened this Jun 20, 2024
@ReneHezser
Copy link
Contributor Author

ReneHezser commented Jun 20, 2024

Oh my. Wrong branch. I need to clean this up. Give me a minute.
Update: fixed

@ReneHezser
Copy link
Contributor Author

ReneHezser commented Jun 20, 2024

The linter complains about comments in the devcontainer.json. But they are supported and help understand the file.
Update: I removed the comments

@ross-p-smith
Copy link

I'm not sure the comments in the devcontainer.json add any value - it's a well known schema and some of the extensions look like they are just commented out. I agree with the linter! :-) (FWIW!)

@ReneHezser ReneHezser merged commit 7d19546 into Azure:main Oct 10, 2024
3 checks passed
@ReneHezser ReneHezser deleted the devcontainer branch October 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: devcontainer for hugo
4 participants