Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small changes to secret export interface description to be more explicit #1447

Conversation

AlexanderSehr
Copy link
Contributor

Overview/Summary

I've noticed that contributors don't attach the Name suffix to each secretName when implementing the interface. With the suggested updates I hope it becomes a bit clearer.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 30, 2024 12:17

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Sep 30, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 30, 2024 12:18
@eriqua eriqua self-requested a review September 30, 2024 13:17
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 764355b into Azure:main Oct 1, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/secretInterfaceTypePropertyName branch October 2, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants