Skip to content

Commit

Permalink
Fix: Null pointer exception in pool picker when using Local Batch acc…
Browse files Browse the repository at this point in the history
…ount (#1851)
  • Loading branch information
timotheeguerin committed Jan 10, 2019
1 parent 83dae8d commit 393a4e5
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@

# 0.19.1

### Bug fixes
* Drilldown into tasks no longer works when filtered [\#1843](https://github.com/Azure/BatchExplorer/issues/1843)
* Create job schedule from job is broken [\#1844](https://github.com/Azure/BatchExplorer/issues/1844)
* Check for updates throws uncaught errors sometimes [\#1847](https://github.com/Azure/BatchExplorer/issues/1847)
* Null pointer exception in pool picker when using Local Batch account [\#1850](https://github.com/Azure/BatchExplorer/issues/1850)

# 0.19.0
[All items](https://github.com/Azure/BatchExplorer/milestone/27?closed=1)

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"name": "Microsoft Corporation",
"email": "[email protected]"
},
"version": "0.19.0",
"version": "0.19.1",
"main": "build/client/main.prod.js",
"scripts": {
"ts": "ts-node --project tsconfig.node.json --files",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export class PoolPickerComponent implements ControlValueAccessor, OnInit, OnDest
}));

this._subs.push(this.vmSizeService.sizes.subscribe((sizes) => {
if (!sizes) {return; }
const vmSizeCoresMap = new Map<string, number>();
sizes.forEach((size) => {
vmSizeCoresMap.set(size.id, size.numberOfCores);
Expand Down

0 comments on commit 393a4e5

Please sign in to comment.