Merge pull request #379 from Azure/vscode

Add vscode install to Tools and install nodejs 18
Azure · Feb 21, 2024 · b9dd996 · b9dd996
2 parents f6c0cc9 + 317bfe3
commit b9dd996
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/linux/base.Dockerfile b/linux/base.Dockerfile
@@ -25,7 +25,7 @@ RUN bash ./tdnfinstall.sh \
 
 # Install nodejs
 RUN bash ./tdnfinstall.sh \
-  nodejs
+  nodejs18
 
 ENV NPM_CONFIG_LOGLEVEL warn
 ENV NODE_ENV production

diff --git a/linux/tools.Dockerfile b/linux/tools.Dockerfile
@@ -29,6 +29,12 @@ RUN az aks install-cli \
     && chmod +x /usr/local/bin/kubectl \
     && chmod +x /usr/local/bin/kubelogin
 
+# Install vscode
+RUN wget -nv -O vscode.tar.gz "https://code.visualstudio.com/sha/download?build=stable&os=cli-alpine-x64" \
+    && tar -xvzf vscode.tar.gz \
+    && mv ./code /bin/vscode \
+    && rm vscode.tar.gz
+
 # Install azure-developer-cli (azd)
 ENV AZD_IN_CLOUDSHELL 1
 ENV AZD_SKIP_UPDATE_CHECK 1

diff --git a/tests/PSinLinuxCloudShellImage.Tests.ps1 b/tests/PSinLinuxCloudShellImage.Tests.ps1
@@ -18,7 +18,7 @@ Describe "Various programs installed with expected versions" {
 
     It "Static Versions" {
         # These programs are installed explicitly with specific versions
-        $script:pmap["Node.JS"].Version | Should -Be '16.20.2'
+        $script:pmap["Node.JS"].Version | Should -Be '18.18.2'
         $script:pmap["PowerShell"].Version | Should -BeLike '7.4*'
     }
 

diff --git a/tests/command_list b/tests/command_list
@@ -1357,6 +1357,7 @@ vipw
 virtualenv
 visudo
 vmstat
+vscode
 w
 wait
 wall
@@ -1436,4 +1437,4 @@ zstd
 zstdcat
 zstdgrep
 zstdless
-zstdmt
+zstdmt