Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vscode install to Tools and install nodejs 18 #379

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Add vscode install to Tools and install nodejs 18 #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b82b48e
add vscode install to tools
Feb 14, 2024
c421a66
update node version
Feb 14, 2024
9b6b547
update command_list
Feb 14, 2024
e270da0
use tarball instead of rpm
Feb 16, 2024
c9e87ad
add vscode to command_list
Feb 20, 2024
317bfe3
Merge branch 'master' of https://github.com/Azure/CloudShell into vscode
Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linux/base.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ RUN bash ./tdnfinstall.sh \

# Install nodejs
RUN bash ./tdnfinstall.sh \
nodejs
nodejs18

ENV NPM_CONFIG_LOGLEVEL warn
ENV NODE_ENV production
Expand Down
6 changes: 6 additions & 0 deletions linux/tools.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ RUN az aks install-cli \
&& chmod +x /usr/local/bin/kubectl \
&& chmod +x /usr/local/bin/kubelogin

# Install vscode
RUN wget -nv -O vscode.tar.gz "https://code.visualstudio.com/sha/download?build=stable&os=cli-alpine-x64" \
&& tar -xvzf vscode.tar.gz \
&& mv ./code /bin/vscode \
&& rm vscode.tar.gz

# Install azure-developer-cli (azd)
ENV AZD_IN_CLOUDSHELL 1
ENV AZD_SKIP_UPDATE_CHECK 1
Expand Down
2 changes: 1 addition & 1 deletion tests/PSinLinuxCloudShellImage.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Describe "Various programs installed with expected versions" {

It "Static Versions" {
# These programs are installed explicitly with specific versions
$script:pmap["Node.JS"].Version | Should -Be '16.20.2'
$script:pmap["Node.JS"].Version | Should -Be '18.18.2'
$script:pmap["PowerShell"].Version | Should -BeLike '7.4*'
}

Expand Down
3 changes: 2 additions & 1 deletion tests/command_list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,6 +1357,7 @@ vipw
virtualenv
visudo
vmstat
vscode
w
wait
wall
Expand Down Expand Up @@ -1436,4 +1437,4 @@ zstd
zstdcat
zstdgrep
zstdless
zstdmt
zstdmt
Loading