feat(designer): Add secure inputs/outputs by default #6678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccastrotrejo
changed the title
…trotrejo/secureInputOutputs
…trotrejo/secureInputOutputs
takyyon
approved these changes
Feb 28, 2025
rllyy97
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Current Behavior
Secure inputs/ouputs are set as false by default for actions that support it.
New Behavior
Now the secure inputs/ouputs are set as true by default for actions that support it and that have the
isSecureByDefaultproperty on their connector. Otherwise the old behavior stays the same wayImpact of Change
This is not a breaking change
Test Plan
Note
Tests Will add e2e test once is deployed to BE in all regions
Risk Low as the assignment is handled with safe access to properties and it always fallback on false, which is the current behavior
Screenshots or Videos (if applicable)
Standard
CleanShot.2025-02-27.at.16.48.47-trimmed.mp4
Consumption
CleanShot.2025-02-28.at.10.02.31.mp4