-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for timeout for ExtPolicy disallowed delete test case #3320
Conversation
self._ssh_client.run_command("update-waagent-conf Debug.EnableExtensionPolicy=y", use_sudo=True) | ||
|
||
# Azure Policy automatically installs the GuestConfig extension on test machines, which may occur | ||
# during the CRP timeout wait (test case 5), inadvertently resetting the timeout period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"inadvertently resetting the timeout period" - what are the consequences of that?
btw, GuestConfig is only one of the extensions installed by policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just makes the test longer - the 15 minute timeout period restarts when CRP gets the GuestConfig enable request. So worst case scenario, GuestConfig is enabled ~14 minutes after the delete request, for a total waiting period of 29 minutes.
What other extensions are installed by policy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved by mistake
Description
Issue #
We are seeing intermittent test failures for the ExtPolicy (ext_policy.py) scenario for the following scenario:
This PR makes the following changes to address this issue:
This PR also makes the following improvements to the test:
PR information
develop
branch.Quality of Code and Contribution Guidelines