Skip to content

Commit

Permalink
Secure value big fix (#52)
Browse files Browse the repository at this point in the history
* Create defaultLabels.yml (#49)

* Create defaultLabels.yml

* Update defaultLabels.yml

* Update defaultLabels.yml (#50)

* use secureValue for secure env variables (#51)

* use secureValue for secure env variables

ContainerInstanceManagementModels.EnvironmentVariable has a property, secureValue, which should be used for secure environment variables.

* Update README.md

Clarify usage of secure-environment-variables. You should specify them as Secrets.

Co-authored-by: el-pato <[email protected]>
  • Loading branch information
kanika1894 and el-pato authored Jun 14, 2021
1 parent 2954073 commit 139a5a4
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 2 deletions.
35 changes: 35 additions & 0 deletions .github/workflows/defaultLabels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: setting-default-labels

# Controls when the action will run.
on:
schedule:
- cron: "0 0/3 * * *"

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
build:
# The type of runner that the job will run on
runs-on: ubuntu-latest

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- uses: actions/stale@v3
name: Setting issue as idle
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'This issue is idle because it has been open for 14 days with no activity.'
stale-issue-label: 'idle'
days-before-stale: 14
days-before-close: -1
operations-per-run: 100
exempt-issue-labels: 'backlog'

- uses: actions/stale@v3
name: Setting PR as idle
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-pr-message: 'This PR is idle because it has been open for 14 days with no activity.'
stale-pr-label: 'idle'
days-before-stale: 14
days-before-close: -1
operations-per-run: 100
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
### Deploying a Container with Environment Variables and Command Line
**NOTE**: Secure Environment Variables aren't masked by the Action so use them as Secrets if you want to hide them
**NOTE**: The values of ```secure-environment-variables``` will not be shown in the properties of the Azure Container Instance, but **will** be shown in the logs of the GitHub Action unless you specify them as Secrets.

```yaml
- uses: Azure/aci-deploy@v1
Expand Down
2 changes: 1 addition & 1 deletion src/taskparameters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class TaskParameters {
let pairList = pair.split(/=(?:"(.+)"|(.+))/);
let obj: ContainerInstanceManagementModels.EnvironmentVariable = {
"name": pairList[0],
"value": pairList[1] || pairList[2]
"secureValue": pairList[1] || pairList[2]
};
this._environmentVariables.push(obj);
})
Expand Down

0 comments on commit 139a5a4

Please sign in to comment.