Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-webapp-on-azure.yml #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shpraka
Copy link
Contributor

@shpraka shpraka commented Oct 6, 2022

  • Added the web publish profile.
  • Removed the installation step of venv as for 3.4 and above it's baked in python.

- Added the web publish profile. 
- Removed the installation step of venv as for 3.4 and above it's baked in python.
@@ -8,16 +8,15 @@ on:
# See this in-depth article on CI for Python applications: https://azure.github.io/AppService/2020/12/11/cicd-for-python-apps.html
#
# 1. Set up the following secrets in your repository:
# AZURE_CREDENTIALS_GITHUB_SECRET
# AZURE_WEBAPP_PUBLISH_PROFILE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Added the explanation in reply to other comment.

Copy link
Contributor

@shubham805 shubham805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants