adds ACA LZA updates

[aarthiem]

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

• [x ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

  • [ x] Azure Container Apps Landing Zone accelerator - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
  • [x ] An architectural guidance with reference architecture and implementation to deploy containerized applications to Azure Container Apps in a secured footprint - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
  • [ x] Architecture Diagram or Application Screenshot - Used as display image for gallery card. The image should include all services and their connections (example). You should add the image to the website/src/data/images/.
  • [ x] Link to Author's GitHub or other relevant website - Used for attribution
  • [x ] Author's Name - Name to credit on the gallery card
  • [x ] Link to template source - Link to the template GitHub repo
  • [x ] Tags - One or more tags representing the template. Provide at least 1 tag for programming language used and at least 1 tag for Azure services integrated. Also tag the IaC provider (Bicep or Terraform). If you don't see a relevant tag for your template? Feel free to add one!

• In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

• [] Name of resource
• [] Resource author - who created this resource? (so we can credit them!)
• [] What section should this resource be included in? -Is the resource an article? A video? Something else?

[hemarina]

@v-xuto Could you validate and test this template when you get a chance?

cc @rajeshkamal5050 @jongio

[v-xuto]

@v-xuto Could you validate and test this template when you get a chance?

cc @rajeshkamal5050 @jongio

@hemarina Sure. But please contact the author to add a Readme for this template (https://github.com/Azure/aca-landing-zone-accelerator), so that we can test it.

[rajeshkamal5050]

@hemarina Sure. But please contact the author to add a Readme for this template (https://github.com/Azure/aca-landing-zone-accelerator), so that we can test it.

@v-xuto I think https://github.com/Azure/aca-landing-zone-accelerator will be a collection of many scenarios and its reference implementations. Currently there is only one scenario being added here https://github.com/Azure/aca-landing-zone-accelerator#rocket-reference-implementation and it contains Bicep and Terraform based deployments which has its respective ReadMe's.

@aarthiem can you clarify on the above and let us know if Bicep and Terraform based deployments are azd compatible and ready for testing?

[jongio]

https://github.com/Azure/aca-landing-zone-accelerator/tree/main/scenarios/aca-internal/bicep

This doc starts with azd, but goes into manual deployment making it seem like the user has to do both of those things.

Can we rearrange this so there are two options:

1. Provision with azd

azd up, etc

2. Manually provision without azd

az commands, etc

[jongio]

This sample should be rearranged so it is easy for a user to either deploy with terraform or with bicep. Right now, there's a hint of using azd with bicep, but nothing for azd with terraform (all those steps are manual).

The structure should be something like:
/README that talks about both
/bicep/azure.yaml
/bicep/infra
/bicep/README
/terraform/azure.yaml
/terraform/infra
/terraform/README

[jongio]

This line should be driven by env vars: https://github.com/Azure/aca-landing-zone-accelerator/blob/main/scenarios/aca-internal/bicep/main.parameters.json#L6

[jongio]

Is this secret that needs to be removed? https://github.com/Azure/aca-landing-zone-accelerator/blob/main/scenarios/aca-internal/bicep/main.parameters.json#L42

[jongio]

Shouldn't this be env var driven? https://github.com/Azure/aca-landing-zone-accelerator/blob/main/scenarios/aca-internal/bicep/main.parameters.json#L72

[jongio]

There are many bicep modules in this repo, that could potentially be adopted to the form of and moved over to our bicep core - or the public bicep registry.