Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote-of-the-day-dotnet template #421

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Add quote-of-the-day-dotnet template #421

merged 9 commits into from
Sep 24, 2024

Conversation

amerjusupovic
Copy link
Member

Your template repository

Place your template repository link here: https://github.com/Azure-Samples/quote-of-the-day-dotnet

(No PR link for when azd compatibility was added since it was originally designed to use azd)

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@amerjusupovic
Copy link
Member Author

amerjusupovic commented Aug 16, 2024

Quick question: when users search for a template after calling azd init, does my template show up as the name in my azure.yaml? Or is it something else

@hemarina
Copy link
Contributor

@v-xuto Could you test this template?

@hemarina
Copy link
Contributor

@amerjusupovic Thank you for your contribution. It will be what you have in title (i.e. Quote of the Day: Feature Experimentation in .NET with Azure App Configuration).

@v-xuto
Copy link
Member

v-xuto commented Aug 19, 2024

@v-xuto Could you test this template?

Testing

@v-xuto
Copy link
Member

v-xuto commented Aug 19, 2024

@hemarina, @amerjusupovic We have finished this template test, and we filed one issue. Please review.

@amerjusupovic
Copy link
Member Author

Thanks, looking into it

@amerjusupovic
Copy link
Member Author

Merged PR with fixes

@v-xuto
Copy link
Member

v-xuto commented Sep 10, 2024

@amerjusupovic We tested based on the latest code, and there are new errors when executing azd up. Please see the comments for more details.

@amerjusupovic
Copy link
Member Author

So sorry about that, I didn't run into this when testing last time. I'll look into it again, thanks

@amerjusupovic
Copy link
Member Author

Updated the linked issue in the quote of the day repo

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@gkulin gkulin merged commit f6ca4e1 into Azure:main Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants