Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Service] Fix #30707: az webapp auth openid-connect add: "scopes" parameter description #8445

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

seligj95
Copy link

@seligj95 seligj95 commented Jan 29, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az webapp auth openid-connect add --scopes

Fixes Azure/azure-cli#30707

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @seligj95,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

github-actions bot commented Jan 29, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 29, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 29, 2025
@seligj95 seligj95 changed the title [App Service] Fix #30707: az webapp auth openid-connect add "scopes" parameter description [App Service] Fix #30707: az webapp auth openid-connect add "scopes" parameter description Jan 29, 2025
@seligj95 seligj95 changed the title [App Service] Fix #30707: az webapp auth openid-connect add "scopes" parameter description [App Service] Fix #30707: az webapp auth openid-connect add: "scopes" parameter description Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reference feedback]:
3 participants