Update ProviderHub CLI Support for Comma Separated Values #8461
Conversation
|
Hi @natzoz, |
|
Hi @natzoz, |
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @natzoz Release SuggestionsModule: providerhub
Notes
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| from azure.cli.core.aaz import AAZArgEnum | ||
| args = str(self.ctx.args).split(",") | ||
| return AAZArgEnum(args) |
There was a problem hiding this comment.
Please follow this doc for customization https://azure.github.io/aaz-dev-tools/pages/usage/customization/
There was a problem hiding this comment.
This is for parsing comma separated input for the following commands:
az providerhub provider-registration create --provider-type
az providerhub resource-type-registration create --routing-type
So that the user could enter something like:
az providerhub provider-registration create --provider-type "Hidden, Internal"
| from azure.cli.core.aaz import AAZArgEnum | ||
| args = str(self.ctx.args).split(",") | ||
| return AAZArgEnum(args) |
There was a problem hiding this comment.
| from azure.cli.core.aaz import AAZArgEnum | |
| args = str(self.ctx.args).split(",") | |
| return AAZArgEnum(args) | |
| pass |
| from azure.cli.core.aaz import AAZArgEnum | ||
| args = str(self.ctx.args).split(",") | ||
| return AAZArgEnum(args) |
There was a problem hiding this comment.
| from azure.cli.core.aaz import AAZArgEnum | |
| args = str(self.ctx.args).split(",") | |
| return AAZArgEnum(args) | |
| pass |
| @@ -213,7 +214,8 @@ def test_step_resource_type_registration_create(self, resource_group): | |||
| '--endpoints "[{{api-versions:[2019-01-01],locations:[WestUS]}}]" ' | |||
| '--regionality "Regional" ' | |||
| '--provider-namespace "{providerNamespace}" ' | |||
| '--resource-type "extensionresourcetype"') | |||
| '--resource-type "extensionresourcetype" ' | |||
| '--routing-type "ProxyOnly, Extension" ') | |||
There was a problem hiding this comment.
| '--routing-type "ProxyOnly, Extension" ') | |
| '--routing-type "ProxyOnly,Extension" ') |
| @@ -171,6 +171,7 @@ def test_step_provider_registration_create(self, resource_group): | |||
| '--incident-routing-service "Resource Provider Service as a Service" ' | |||
| '--incident-routing-team "RPaaS" ' | |||
| '--provider-version "2.0" ' | |||
| '--provider-type "Hidden, Internal" ' | |||
There was a problem hiding this comment.
| '--provider-type "Hidden, Internal" ' | |
| '--provider-type "Hidden,Internal" ' |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az providerhub
This update fixes a bug for allowing comma separated values for the following arguments:
az providerhub provider-registration create --provider-type
az providerhub resource-type-registration create --routing-type
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.