-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aks-preview-extension: Add --max-unavailablemto the az aks nodepool add/update/upgrade
commands
#8478
base: main
Are you sure you want to change the base?
Conversation
…o true and increment mcc version to v1.0.0b2 from v1.0.0b1 (Azure#8295)
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111848893&view=results Last commit: Azure@0c0719a
* start using 2024 api version * update tests * update version * use suggested version
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111849276&view=results Last commit: Azure@d7beb76
* Handle no tty pwinput Pwinput : When terminal / tty is not available, read from stdin * update version * fix lint issue
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111849784&view=results Last commit: Azure@28ae98d
…8393) * updating docs and bugfix for fragments * decoupling fragment feed from image push target * adding --omit-id to acifragmentgen * updating version number * adding bugfix and test for persistent volume template * consolidating to version 1.1.2 from 1.1.3 * style fixes * fixing tests * commenting out some tests for now until we figure out how to run the bash script * updating rules * updating version number
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111852029&view=results Last commit: Azure@e9a3e11
* Check if "isFolder" exists before validation * update pe test recording * Switch to folder overwrite * Change link in string and regenerate relevant test recordings --------- Co-authored-by: Alan Zhang <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111853570&view=results Last commit: Azure@f739bdb
…nfiguration (Azure#8381) * Add list of allowed classifications in description for Maintenance Configuration * Update HISTORY.rst * Update setup.py and tests --------- Co-authored-by: Sethuram S <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111856340&view=results Last commit: Azure@ac3f6a2
* Update project env type parameters * Fix environment def example and update style * Fix show logs * Fix spacing * Fix style error * Fix integraion tests * Fix gallery test * Fix gallery test * Fix gallery compute * Update * Update control plane * Update tests and vendored sdk for data plane API * Updates * Update tests * Update version * Update tests * Update log command to support escape characters * Update control plane to 2024-10-01-preview * Changes for force delete only * update api version * remove preview flag * Fix linter errors * Update control plane tests * Update tests * Update commands * Add project policy test * Update * add missing override * Update response * Add tests * Fix image name regex * Update version for Ignite * Update data plane tests * Update control plane tests * Fix control plane tests * Fix nsg * Update params * Update release version * Update data plane 2024-10-01-preview * Remove old dp code * Add devbox list * Add project,pool,schedule * Add devbox * Fix post, add snapshots * Fix post LRO * Add environments * Add additional cmds * Fix help * Fix params * Fix customization task validate * Linter and style fixes * Update version * Update version2 * Update dp tests * Add dev box tests * Add repair test * Add snapshot test * Add customization task test * Add customization group test * Add environment test * Update tests * Update help * Fix tests --------- Co-authored-by: Erica Guthan <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111856652&view=results Last commit: Azure@79ee9df
…Enhanced Security Compliance feature (Azure#8353) * Update ESC support by adding new intuitive parameters * Add shorter alternatives to the options, add default values to compliance standards * Add test and update history * Bump version * Bump version by following the versioning guidelines * Add old parameters back
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111858094&view=results Last commit: Azure@b9f871a
* add azdev scan - Pro task * test * error msg style * continue on failure * echo -> printf * revert test change * rename task * fix
…ure#8362) * Updating api version and changing namespace commands to scheduler Signed-off-by: Ryan Lettieri <[email protected]> * Updating some docs and upgrading version Signed-off-by: Ryan Lettieri <[email protected]> * Expanding sku into 2 separate arguments Signed-off-by: Ryan Lettieri <[email protected]> --------- Signed-off-by: Ryan Lettieri <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111969271&view=results Last commit: Azure@a4d59c7
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=111975412&view=results Last commit: Azure@744f874
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Queued live test to validate the change, test passed!
|
@microsoft-github-policy-service agree company="Microsoft" |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Please fix failed CI checks. |
/azp run |
Commenter does not have sufficient privileges for PR 8478 in repo Azure/azure-cli-extensions |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Please fix the following error.
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Add --max-unavailable to the
az aks nodepool add/update/upgrade
commandsGeneral Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.