Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-premium disk option for repair VM #8486

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Feb 18, 2025


This PR adds a new parameter to set the os disk storage account type of the repair vm to be whatever the user wants.
This allows users who have restrictions on creating premium disks in their environments to use the repair vm feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Feb 18, 2025

Hi @Sandido

⚠️ Release Requirements

Module: vm-repair

  • ⚠️ Please update VERSION to be 2.1.0 in src/vm-repair/setup.py

Notes

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 18, 2025

Please fix conflicts

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 20, 2025
@Sandido Sandido marked this pull request as ready for review February 20, 2025 21:20
@github-actions github-actions bot added release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Feb 20, 2025
2.0.4
++++++
Added new parameter `os-disk-type` to `vm repair create` to let users specify the repair vm's os disk storage account type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new parameter is a feature for vm-repair and therefore new version should be 2.1.0.

For more info about extension versioning, please refer to the doc here: https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#cli-extension-version-transition-table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants