-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-premium disk option for repair VM #8486
base: main
Are you sure you want to change the base?
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @Sandido, |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Hi @Sandido
|
Please fix conflicts |
2.0.4 | ||
++++++ | ||
Added new parameter `os-disk-type` to `vm repair create` to let users specify the repair vm's os disk storage account type. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding new parameter is a feature for vm-repair and therefore new version should be 2.1.0
.
For more info about extension versioning, please refer to the doc here: https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#cli-extension-version-transition-table
This PR adds a new parameter to set the os disk storage account type of the repair vm to be whatever the user wants.
This allows users who have restrictions on creating premium disks in their environments to use the repair vm feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair create
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.