Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/update: Update recording rule group create logic for managed prometheus addon #8499

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Feb 21, 2025

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"

az aks create -n kaveeshcli22 -g kaveeshcli --disable-azure-monitor-metrics

Testing Guide

Scenario 1 : Region where TiP manifest is available

  • Enable Microsoft.AlertsManagement/testinproduction in your subscription
  • Use the command with and without the azure-monitor-workspace-resource-id parameter similar to az aks create -n kaveeshcli22 -g kaveeshcli --location westcentralus --enable-azure-monitor-metrics" and it should result in a success. (Currently the change is only deployed to westcentralus)

Scenario 2 : Region where TiP manifest is not available

  • Use the command with and without the azure-monitor-workspace-resource-id parameter similar to az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics" and it should result in a success.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 21, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 21, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants