Skip to content

PureStorage Cli onboard #8992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

deepakmauryams
Copy link
Member

@deepakmauryams deepakmauryams commented Jul 22, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 12:38
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @deepakmauryams,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Azure CLI extension for managing PureStorage Cloud resources, providing commands for managing storage pools and reservations. The extension adds command groups under the pscloud namespace with full CRUD operations and specialized functionality.

  • Full CLI extension structure for PureStorage Cloud integration
  • Storage pool management commands (create, delete, update, list, show, wait, get-health-status, get-avs-status)
  • Reservation management commands (delete, list, show, wait)

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/service_name.json Adds service name mapping for pscloud commands
src/pscloud/setup.py Extension package configuration with metadata and dependencies
src/pscloud/azext_pscloud/ Core extension module with command loading and argument handling
src/pscloud/azext_pscloud/aaz/latest/pscloud/ Auto-generated command implementations for storage pools and reservations
src/pscloud/azext_pscloud/tests/ Test framework structure (placeholder implementation)
Comments suppressed due to low confidence (1)

src/pscloud/azext_pscloud/tests/latest/test_pscloud.py:13

  • The test class contains only a TODO comment and pass statement, providing no actual test coverage for the pscloud extension functionality. Consider implementing tests for the core extension loading, command registration, and basic command execution.
    pass

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants