-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(cnl): Update stream for retina-operator 0.1.14 and ama agent update #9342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @snguyen64, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @snguyen64 Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the aks-preview extension to version 19.0.0b12, changing the data collection stream name from Microsoft-RetinaNetworkFlowLogs to Microsoft-ContainerNetworkLogs for the container network logs feature.
- Version bumped to 19.0.0b12
- Stream name updated from
Microsoft-RetinaNetworkFlowLogstoMicrosoft-ContainerNetworkLogs - Test assertions updated to verify the new stream name
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version bumped to 19.0.0b12 |
| src/aks-preview/HISTORY.rst | Added release notes for version 19.0.0b12 documenting the stream name change |
| src/aks-preview/azext_aks_preview/addonconfiguration.py | Updated ContainerInsightsStreams array to use Microsoft-ContainerNetworkLogs instead of Microsoft-RetinaNetworkFlowLogs |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Updated test assertion to check for the new Microsoft-ContainerNetworkLogs stream name in DCR |
This updates dcr stream for container network logs. This is for updated ama and retina-operator versions pending rollout.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Should not impact commands
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.