Skip to content

Conversation

@berndverst
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az durabletask

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 3, 2025 06:01
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 3, 2025

❌Azure CLI Extensions Breaking Change Test
❌durabletask
rule cmd_name rule_message suggest_message
1002 - CmdRemove durabletask taskhub update cmd durabletask taskhub update removed please confirm cmd durabletask taskhub update removed
⚠️ 1008 - ParaPropAdd durabletask scheduler create cmd durabletask scheduler create update parameter sku_name: added property choices=['Consumption', 'Dedicated']
⚠️ 1008 - ParaPropAdd durabletask scheduler update cmd durabletask scheduler update update parameter sku_name: added property choices=['Consumption', 'Dedicated']

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@berndverst
Copy link
Member Author

FYI I'm one of the Service Tree, ARM Manifest and Swagger Spec owners. I also released all other language SDKs.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@berndverst
Copy link
Member Author

@yonzhan and @kairu-ms - if you could help merge this and also assist with the release process that would be fantastic. It's my first time releasing our CLI extension and I'm unclear what the process is once the PR is merged. Thanks!

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the durabletask Azure CLI extension to version 1.0.0b5, upgrading to the first stable ARM API version 2025-11-01. The changes drop support for Python 3.7 and 3.8 while adding support for Python 3.10-3.13, and update the minimum Azure CLI core version requirement.

Key changes:

  • API version upgrade from preview versions to stable 2025-11-01
  • Python version support updated (removed 3.7, 3.8; added 3.10-3.13)
  • Improved CLI parameter naming and SKU enum constraints
  • Enhanced documentation for retention policy commands

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/durabletask/setup.py Bumped version to 1.0.0b5 and updated Python version classifiers
src/durabletask/azext_durabletask/azext_metadata.json Updated minimum CLI core version requirement to 2.75.0
src/durabletask/azext_durabletask/aaz/latest/durabletask/taskhub/_update.py Removed @register_command decorator, renamed parameter from name to task_hub_name, removed -s shorthand for scheduler-name, updated API version
src/durabletask/azext_durabletask/aaz/latest/durabletask/taskhub/_wait.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/taskhub/_show.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/taskhub/_list.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/taskhub/_delete.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/taskhub/_create.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_update.py Added SKU enum constraints, updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_wait.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_show.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_list.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_delete.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/scheduler/_create.py Added SKU enum constraints, updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/retention_policy/_update.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/retention_policy/_wait.py Updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/retention_policy/_show.py Removed example comments from docstring, updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/retention_policy/_delete.py Updated docstring to be concise, removed example comments, updated API version to 2025-11-01
src/durabletask/azext_durabletask/aaz/latest/durabletask/retention_policy/_create.py Updated docstring, added retention-policies argument with options and help text, removed blank line, updated API version to 2025-11-01
src/durabletask/README.md Added retention-policy command documentation and examples
src/durabletask/HISTORY.rst Added release notes for version 1.0.0b5


from azure.cli.core.aaz import *


Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @register_command decorator was removed from the Update class, but other similar command classes in the codebase (e.g., _create.py, _delete.py, _show.py) still have this decorator. This inconsistency will prevent the 'durabletask taskhub update' command from being registered and available to users. The decorator should be added back: @register_command(\"durabletask taskhub update\",) before the class definition.

Suggested change
@register_command("durabletask taskhub update",)

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the register_command decoration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am removing this from the command table because it should never have been added. This was a mistake from the previous author.
We do not actually have a PATCH Microsoft.DurableTask/schedulers/taskhubs operation that does anything. You can technically make that operation with an empty payload but it does not do anything.
To avoid confusion I am removing it. Consider this a fixup!

@kairu-ms
Copy link
Contributor

kairu-ms commented Nov 3, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@berndverst
Copy link
Member Author

By the way, the TaskHub update command is removed intentionally @kairu-ms, @jsntcy @yonzhan. As you can see before, this command did not do anything - it did not have any attributes to actually update. So this breaking change is actually a fixup to avoid customer confusion.

@kairu-ms
Copy link
Contributor

kairu-ms commented Nov 3, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit a2ecd95 into Azure:main Nov 5, 2025
25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 5, 2025

[Release] Update index.json for extension [ durabletask-1.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142670360&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants