Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Pylint} Fix use-list-literal #20237

Merged
merged 2 commits into from
Nov 9, 2021
Merged

{Pylint} Fix use-list-literal #20237

merged 2 commits into from
Nov 9, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Nov 8, 2021 •
edited
Loading

Description

Part of #20192

Fix linter error R1734:

R1734: Consider using [] instead of list() (use-list-literal)

https://pylint.pycqa.org/en/latest/technical_reference/features.html#imports-checker-messages

use-list-literal (R1734)
Consider using [] instead of list() Emitted when using list() to create an empty list instead of the literal []. The literal is faster as it avoids an additional function call.

@jiasli jiasli requested a review from wangzelin007 November 8, 2021 09:21
@jiasli jiasli added this to the Nov 2021 (2021-12-07) milestone Nov 8, 2021
@jiasli jiasli self-assigned this Nov 8, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 8, 2021

Pylint

wangzelin007
wangzelin007 approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiasli jiasli merged commit 15c17c0 into Azure:dev Nov 9, 2021
@jiasli jiasli deleted the use-list-literal branch November 9, 2021 07:49
@jiasli jiasli mentioned this pull request Nov 14, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evelyn-ys evelyn-ys evelyn-ys approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@calvinhzy calvinhzy calvinhzy approved these changes

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@kairu-ms kairu-ms kairu-ms approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@panchagnula panchagnula Awaiting requested review from panchagnula

Assignees

@jiasli jiasli

Labels
None yet
Projects
None yet
Milestone
Nov 2021 (2021-12-07)
Development

Successfully merging this pull request may close these issues.
7 participants
@jiasli @yonzhan @evelyn-ys @zhoxing-ms @calvinhzy @wangzelin007 @kairu-ms