[Service Connector] az webapp/containerapp/spring connection create/update: Support opt out action
#28079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @wchigit, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp connection create app-insights | cmd containerapp connection create app-insights added parameter opt_out_list |
||
| containerapp connection create appconfig | cmd containerapp connection create appconfig added parameter opt_out_list |
||
| containerapp connection create confluent-cloud | cmd containerapp connection create confluent-cloud added parameter opt_out_list |
||
| containerapp connection create cosmos-cassandra | cmd containerapp connection create cosmos-cassandra added parameter opt_out_list |
||
| containerapp connection create cosmos-gremlin | cmd containerapp connection create cosmos-gremlin added parameter opt_out_list |
||
| containerapp connection create cosmos-mongo | cmd containerapp connection create cosmos-mongo added parameter opt_out_list |
||
| containerapp connection create cosmos-sql | cmd containerapp connection create cosmos-sql added parameter opt_out_list |
||
| containerapp connection create cosmos-table | cmd containerapp connection create cosmos-table added parameter opt_out_list |
||
| containerapp connection create eventhub | cmd containerapp connection create eventhub added parameter opt_out_list |
||
| containerapp connection create keyvault | cmd containerapp connection create keyvault added parameter opt_out_list |
||
| containerapp connection create mysql | cmd containerapp connection create mysql added parameter opt_out_list |
||
| containerapp connection create mysql-flexible | cmd containerapp connection create mysql-flexible added parameter opt_out_list |
||
| containerapp connection create postgres | cmd containerapp connection create postgres added parameter opt_out_list |
||
| containerapp connection create postgres-flexible | cmd containerapp connection create postgres-flexible added parameter opt_out_list |
||
| containerapp connection create redis | cmd containerapp connection create redis added parameter opt_out_list |
||
| containerapp connection create redis-enterprise | cmd containerapp connection create redis-enterprise added parameter opt_out_list |
||
| containerapp connection create servicebus | cmd containerapp connection create servicebus added parameter opt_out_list |
||
| containerapp connection create signalr | cmd containerapp connection create signalr added parameter opt_out_list |
||
| containerapp connection create sql | cmd containerapp connection create sql added parameter opt_out_list |
||
| containerapp connection create storage-blob | cmd containerapp connection create storage-blob added parameter opt_out_list |
||
| containerapp connection create storage-file | cmd containerapp connection create storage-file added parameter opt_out_list |
||
| containerapp connection create storage-queue | cmd containerapp connection create storage-queue added parameter opt_out_list |
||
| containerapp connection create storage-table | cmd containerapp connection create storage-table added parameter opt_out_list |
||
| containerapp connection create webpubsub | cmd containerapp connection create webpubsub added parameter opt_out_list |
||
| containerapp connection update app-insights | cmd containerapp connection update app-insights added parameter opt_out_list |
||
| containerapp connection update appconfig | cmd containerapp connection update appconfig added parameter opt_out_list |
||
| containerapp connection update confluent-cloud | cmd containerapp connection update confluent-cloud added parameter opt_out_list |
||
| containerapp connection update cosmos-cassandra | cmd containerapp connection update cosmos-cassandra added parameter opt_out_list |
||
| containerapp connection update cosmos-gremlin | cmd containerapp connection update cosmos-gremlin added parameter opt_out_list |
||
| containerapp connection update cosmos-mongo | cmd containerapp connection update cosmos-mongo added parameter opt_out_list |
||
| containerapp connection update cosmos-sql | cmd containerapp connection update cosmos-sql added parameter opt_out_list |
||
| containerapp connection update cosmos-table | cmd containerapp connection update cosmos-table added parameter opt_out_list |
||
| containerapp connection update eventhub | cmd containerapp connection update eventhub added parameter opt_out_list |
||
| containerapp connection update keyvault | cmd containerapp connection update keyvault added parameter opt_out_list |
||
| containerapp connection update mysql | cmd containerapp connection update mysql added parameter opt_out_list |
||
| containerapp connection update mysql-flexible | cmd containerapp connection update mysql-flexible added parameter opt_out_list |
||
| containerapp connection update postgres | cmd containerapp connection update postgres added parameter opt_out_list |
||
| containerapp connection update postgres-flexible | cmd containerapp connection update postgres-flexible added parameter opt_out_list |
||
| containerapp connection update redis | cmd containerapp connection update redis added parameter opt_out_list |
||
| containerapp connection update redis-enterprise | cmd containerapp connection update redis-enterprise added parameter opt_out_list |
||
| containerapp connection update servicebus | cmd containerapp connection update servicebus added parameter opt_out_list |
||
| containerapp connection update signalr | cmd containerapp connection update signalr added parameter opt_out_list |
||
| containerapp connection update sql | cmd containerapp connection update sql added parameter opt_out_list |
||
| containerapp connection update storage-blob | cmd containerapp connection update storage-blob added parameter opt_out_list |
||
| containerapp connection update storage-file | cmd containerapp connection update storage-file added parameter opt_out_list |
||
| containerapp connection update storage-queue | cmd containerapp connection update storage-queue added parameter opt_out_list |
||
| containerapp connection update storage-table | cmd containerapp connection update storage-table added parameter opt_out_list |
||
| containerapp connection update webpubsub | cmd containerapp connection update webpubsub added parameter opt_out_list |
||
| functionapp connection create app-insights | cmd functionapp connection create app-insights added parameter opt_out_list |
||
| functionapp connection create appconfig | cmd functionapp connection create appconfig added parameter opt_out_list |
||
| functionapp connection create confluent-cloud | cmd functionapp connection create confluent-cloud added parameter opt_out_list |
||
| functionapp connection create cosmos-cassandra | cmd functionapp connection create cosmos-cassandra added parameter opt_out_list |
||
| functionapp connection create cosmos-gremlin | cmd functionapp connection create cosmos-gremlin added parameter opt_out_list |
||
| functionapp connection create cosmos-mongo | cmd functionapp connection create cosmos-mongo added parameter opt_out_list |
||
| functionapp connection create cosmos-sql | cmd functionapp connection create cosmos-sql added parameter opt_out_list |
||
| functionapp connection create cosmos-table | cmd functionapp connection create cosmos-table added parameter opt_out_list |
||
| functionapp connection create eventhub | cmd functionapp connection create eventhub added parameter opt_out_list |
||
| functionapp connection create keyvault | cmd functionapp connection create keyvault added parameter opt_out_list |
||
| functionapp connection create mysql | cmd functionapp connection create mysql added parameter opt_out_list |
||
| functionapp connection create mysql-flexible | cmd functionapp connection create mysql-flexible added parameter opt_out_list |
||
| functionapp connection create postgres | cmd functionapp connection create postgres added parameter opt_out_list |
||
| functionapp connection create postgres-flexible | cmd functionapp connection create postgres-flexible added parameter opt_out_list |
||
| functionapp connection create redis | cmd functionapp connection create redis added parameter opt_out_list |
||
| functionapp connection create redis-enterprise | cmd functionapp connection create redis-enterprise added parameter opt_out_list |
||
| functionapp connection create servicebus | cmd functionapp connection create servicebus added parameter opt_out_list |
||
| functionapp connection create signalr | cmd functionapp connection create signalr added parameter opt_out_list |
||
| functionapp connection create sql | cmd functionapp connection create sql added parameter opt_out_list |
||
| functionapp connection create storage-blob | cmd functionapp connection create storage-blob added parameter opt_out_list |
||
| functionapp connection create storage-file | cmd functionapp connection create storage-file added parameter opt_out_list |
||
| functionapp connection create storage-queue | cmd functionapp connection create storage-queue added parameter opt_out_list |
||
| functionapp connection create storage-table | cmd functionapp connection create storage-table added parameter opt_out_list |
||
| functionapp connection create webpubsub | cmd functionapp connection create webpubsub added parameter opt_out_list |
||
| functionapp connection update app-insights | cmd functionapp connection update app-insights added parameter opt_out_list |
||
| functionapp connection update appconfig | cmd functionapp connection update appconfig added parameter opt_out_list |
||
| functionapp connection update confluent-cloud | cmd functionapp connection update confluent-cloud added parameter opt_out_list |
||
| functionapp connection update cosmos-cassandra | cmd functionapp connection update cosmos-cassandra added parameter opt_out_list |
||
| functionapp connection update cosmos-gremlin | cmd functionapp connection update cosmos-gremlin added parameter opt_out_list |
||
| functionapp connection update cosmos-mongo | cmd functionapp connection update cosmos-mongo added parameter opt_out_list |
||
| functionapp connection update cosmos-sql | cmd functionapp connection update cosmos-sql added parameter opt_out_list |
||
| functionapp connection update cosmos-table | cmd functionapp connection update cosmos-table added parameter opt_out_list |
||
| functionapp connection update eventhub | cmd functionapp connection update eventhub added parameter opt_out_list |
||
| functionapp connection update keyvault | cmd functionapp connection update keyvault added parameter opt_out_list |
||
| functionapp connection update mysql | cmd functionapp connection update mysql added parameter opt_out_list |
||
| functionapp connection update mysql-flexible | cmd functionapp connection update mysql-flexible added parameter opt_out_list |
||
| functionapp connection update postgres | cmd functionapp connection update postgres added parameter opt_out_list |
||
| functionapp connection update postgres-flexible | cmd functionapp connection update postgres-flexible added parameter opt_out_list |
||
| functionapp connection update redis | cmd functionapp connection update redis added parameter opt_out_list |
||
| functionapp connection update redis-enterprise | cmd functionapp connection update redis-enterprise added parameter opt_out_list |
||
| functionapp connection update servicebus | cmd functionapp connection update servicebus added parameter opt_out_list |
||
| functionapp connection update signalr | cmd functionapp connection update signalr added parameter opt_out_list |
||
| functionapp connection update sql | cmd functionapp connection update sql added parameter opt_out_list |
||
| functionapp connection update storage-blob | cmd functionapp connection update storage-blob added parameter opt_out_list |
||
| functionapp connection update storage-file | cmd functionapp connection update storage-file added parameter opt_out_list |
||
| functionapp connection update storage-queue | cmd functionapp connection update storage-queue added parameter opt_out_list |
||
| functionapp connection update storage-table | cmd functionapp connection update storage-table added parameter opt_out_list |
||
| functionapp connection update webpubsub | cmd functionapp connection update webpubsub added parameter opt_out_list |
||
| webapp connection create app-insights | cmd webapp connection create app-insights added parameter opt_out_list |
||
| webapp connection create appconfig | cmd webapp connection create appconfig added parameter opt_out_list |
||
| webapp connection create confluent-cloud | cmd webapp connection create confluent-cloud added parameter opt_out_list |
||
| webapp connection create cosmos-cassandra | cmd webapp connection create cosmos-cassandra added parameter opt_out_list |
||
| webapp connection create cosmos-gremlin | cmd webapp connection create cosmos-gremlin added parameter opt_out_list |
||
| webapp connection create cosmos-mongo | cmd webapp connection create cosmos-mongo added parameter opt_out_list |
||
| webapp connection create cosmos-sql | cmd webapp connection create cosmos-sql added parameter opt_out_list |
||
| webapp connection create cosmos-table | cmd webapp connection create cosmos-table added parameter opt_out_list |
||
| webapp connection create eventhub | cmd webapp connection create eventhub added parameter opt_out_list |
||
| webapp connection create keyvault | cmd webapp connection create keyvault added parameter opt_out_list |
||
| webapp connection create mysql | cmd webapp connection create mysql added parameter opt_out_list |
||
| webapp connection create mysql-flexible | cmd webapp connection create mysql-flexible added parameter opt_out_list |
||
| webapp connection create postgres | cmd webapp connection create postgres added parameter opt_out_list |
||
| webapp connection create postgres-flexible | cmd webapp connection create postgres-flexible added parameter opt_out_list |
||
| webapp connection create redis | cmd webapp connection create redis added parameter opt_out_list |
||
| webapp connection create redis-enterprise | cmd webapp connection create redis-enterprise added parameter opt_out_list |
||
| webapp connection create servicebus | cmd webapp connection create servicebus added parameter opt_out_list |
||
| webapp connection create signalr | cmd webapp connection create signalr added parameter opt_out_list |
||
| webapp connection create sql | cmd webapp connection create sql added parameter opt_out_list |
||
| webapp connection create storage-blob | cmd webapp connection create storage-blob added parameter opt_out_list |
||
| webapp connection create storage-file | cmd webapp connection create storage-file added parameter opt_out_list |
||
| webapp connection create storage-queue | cmd webapp connection create storage-queue added parameter opt_out_list |
||
| webapp connection create storage-table | cmd webapp connection create storage-table added parameter opt_out_list |
||
| webapp connection create webpubsub | cmd webapp connection create webpubsub added parameter opt_out_list |
||
| webapp connection update app-insights | cmd webapp connection update app-insights added parameter opt_out_list |
||
| webapp connection update appconfig | cmd webapp connection update appconfig added parameter opt_out_list |
||
| webapp connection update confluent-cloud | cmd webapp connection update confluent-cloud added parameter opt_out_list |
||
| webapp connection update cosmos-cassandra | cmd webapp connection update cosmos-cassandra added parameter opt_out_list |
||
| webapp connection update cosmos-gremlin | cmd webapp connection update cosmos-gremlin added parameter opt_out_list |
||
| webapp connection update cosmos-mongo | cmd webapp connection update cosmos-mongo added parameter opt_out_list |
||
| webapp connection update cosmos-sql | cmd webapp connection update cosmos-sql added parameter opt_out_list |
||
| webapp connection update cosmos-table | cmd webapp connection update cosmos-table added parameter opt_out_list |
||
| webapp connection update eventhub | cmd webapp connection update eventhub added parameter opt_out_list |
||
| webapp connection update keyvault | cmd webapp connection update keyvault added parameter opt_out_list |
||
| webapp connection update mysql | cmd webapp connection update mysql added parameter opt_out_list |
||
| webapp connection update mysql-flexible | cmd webapp connection update mysql-flexible added parameter opt_out_list |
||
| webapp connection update postgres | cmd webapp connection update postgres added parameter opt_out_list |
||
| webapp connection update postgres-flexible | cmd webapp connection update postgres-flexible added parameter opt_out_list |
||
| webapp connection update redis | cmd webapp connection update redis added parameter opt_out_list |
||
| webapp connection update redis-enterprise | cmd webapp connection update redis-enterprise added parameter opt_out_list |
||
| webapp connection update servicebus | cmd webapp connection update servicebus added parameter opt_out_list |
||
| webapp connection update signalr | cmd webapp connection update signalr added parameter opt_out_list |
||
| webapp connection update sql | cmd webapp connection update sql added parameter opt_out_list |
||
| webapp connection update storage-blob | cmd webapp connection update storage-blob added parameter opt_out_list |
||
| webapp connection update storage-file | cmd webapp connection update storage-file added parameter opt_out_list |
||
| webapp connection update storage-queue | cmd webapp connection update storage-queue added parameter opt_out_list |
||
| webapp connection update storage-table | cmd webapp connection update storage-table added parameter opt_out_list |
||
| webapp connection update webpubsub | cmd webapp connection update webpubsub added parameter opt_out_list |
microsoft-github-policy-service
bot
requested review from
jsntcy,
zhoxing-ms,
yonzhan and
wangzelin007
|
Service Connector |
microsoft-github-policy-service
bot
requested review from
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
3 tasks
yungezz
reviewed
Jan 4, 2024
src/azure-cli/azure/cli/command_modules/serviceconnector/_resource_config.py
Outdated
Show resolved
Hide resolved
houk-ms
reviewed
Jan 8, 2024
src/azure-cli/azure/cli/command_modules/serviceconnector/_resource_config.py
Show resolved
Hide resolved
|
@kairu-ms Could you please review this PR? Thanks. |
AllyW
approved these changes
Jan 25, 2024
@wchigit please update the History Notes part in pr description, for later release doc generation, according to this guideline https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests |
|
@yanzhudd, need your review as an owner. |
necusjz
approved these changes
Jan 25, 2024
yanzhudd
approved these changes
Jan 29, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp connection create --source-id --target-id --opt-out publicnetwork configinfo
az webapp connection update --source-id --target-id --opt-out publicnetwork configinfo
Description
This PR enables an opt-out option during the creation and the updates of Service Connector. Users can choose to skip the configuration settings on source service and the public network configuration on target service by adding arguments after '--opt-out'. This parameter is optional.
Testing Guide
Create a service linker for App Service and Storage Blob without configuring public network and app settings:
az webapp connection create storage-blob --connection {connection-name} --source-id {source-id} --target-id {target-id} --secret --client-type dotnet --opt-out publicnetwork configinfo
Create a service linker for App Service and Storage Blob without configuring firewall rules on storage:
az webapp connection create storage-blob --connection {connection-name} --source-id {source-id} --target-id {target-id} --secret --client-type dotnet --opt-out publicnetwork
Update a service linker with no configuration changes on source
az webapp connection update storage-blob --id {conneciton-id} --client-type dotnet --opt-out configinfo
History Notes
[Service Connector]
az webapp/containerapp/spring connection create/update: Support opt out action for configurationInfo and publicNetworkThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.