{Pylint} Fix used-before-assignment #30348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
evelyn-ys and
calvinhzy
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
12 tasks
FumingZhang
reviewed
Nov 15, 2024
| @@ -770,7 +770,7 @@ def create_data_collection_endpoint(cmd, subscription, resource_group, region, e | |||
| def validate_data_collection_settings(dataCollectionSettings): | |||
| if 'interval' in dataCollectionSettings.keys(): | |||
| intervalValue = dataCollectionSettings["interval"] | |||
| if (bool(re.match(r'^[0-9]+[m]$', intervalValue))) is False: | |||
| if (bool(re.match(r'^[0-9]+[m]$', intervalValue))) is False: # pylint: disable=used-before-assignment | |||
There was a problem hiding this comment.
@ganga1980 could you please help fix these issues?
zhoxing-ms
previously approved these changes
Nov 15, 2024
FumingZhang
approved these changes
Nov 15, 2024
jiasli
force-pushed
the
used-before-assignment
branch
from
d26b395 to
caddb49
Compare
bebound
approved these changes
Nov 20, 2024
zhoxing-ms
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finish the unfinished tasks of #20192
Fix
used-before-assignment: https://pylint.readthedocs.io/en/stable/user_guide/messages/error/used-before-assignment.html