[AppConfig] appconfig kv import: Fix import mode all bug
#30489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertofori
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
avanigupta
microsoft-github-policy-service
bot
added
App Configuration
Auto-Assign
ChristineWanjau
approved these changes
Dec 9, 2024
avanigupta
reviewed
Dec 9, 2024
| @@ -52,7 +52,7 @@ def compare(self, dest_kvs, strict=False): | |||
| kv_diff[JsonDiff.ADD].append(kv) | |||
|
|
|||
| else: | |||
| if not self._kv_equals(kv, dest_kv_lookup[lookup_key], self._compare_fields): | |||
| if not (ignore_matching_kvs and self._kv_equals(kv, dest_kv_lookup[lookup_key], self._compare_fields)): | |||
There was a problem hiding this comment.
if import mode is all, we dont need to check for updates?
There was a problem hiding this comment.
Since we will be overwriting the existing kvs anyways, if a kv already exists, my thought was to consider that an update even if it is unchanged
avanigupta
approved these changes
Dec 9, 2024
|
@zhoxing-ms, @yanzhudd, Could you please help merge this PR, thanks! |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig kv importDescription
Related to Issue Azure/AppConfiguration#998 where import mode
allwill not write kvs when all keys already existing and the--yesflag is not specified.Testing Guide
History Notes
[AppConfig]
az appconfig kv import: Fix import modeallbugThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.