{cli} Changes for adding an optional field for Filtering to Azure Cli commands for flowlogs resource creation and updation #30581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansi-verma-1510
requested review from
jsntcy,
kairu-ms,
wangzelin007 and
necusjz
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
|
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related commands
Description
This PR introduces a new optional field, "filtering-criteria," for the creation and update of the Flowlogs resource. Necessary validations for this field have already been implemented in NRP. Unit tests for this feature have been added as part of this PR.
Additionally, screenshots of the testing performed, beyond unit tests, are included below.
Testing Guide
Help command shows the new field and its proper explanation:
az network watcher flow-log create --location eastus2euap --resource-group riddhi_rg3 --name vnet-eastus2euap-flowlog --vnet vnet-eastus2euap --storage-account riddhisa3 --filtering-criteria "dstip=20.252.145.59 || DstPort=443"az network watcher flow-log show --location eastus2euap --name vnet-eastus2euap-flowlogValidations for filtering field happens in NRP
Expected error when the condition is not in the expected format of key value pairs combined with relational operators.
The length of the value passed to filtering-criteria should not exceed 1000.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.