Skip to content

backport: Windows HPC base image (#3105) #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/v1.5
Choose a base branch
from

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Dec 13, 2024

Windows HPC are special.

They explicitly do not run in a chroot or similar execution sandbox, and their filesystem is a merged view of the hostfs and their shipped containerfs. This means that we don't need to ship a filesystem: we recently moved from servercore to nanoserver and observed that the lack of pwsh.exe in nanoserver is manageable (in containerd 1.7+, automatically, and in 1.6, by tweaking the container PATH). We can go further and remove the rest of the OS since, as HPC, we don't need it and can escape to the hostfs for dependencies like powershell.

Further, HPC do not have the containerd/containerd#7431 (the "os-version") as regular Windows containers - any Windows HPC may run on any Windows Server Host (given the executables are compatible with that Host).
In some of the testing with WS25 we have seen that this may happen - it was observed that containerd on WS25 inconsistently fetched the WS25 CNI image specified in our multiplatform manifest but was able to run other WS images without any issue.
Containerd >= 1.6 containerd/containerd#8101, so we don't need to build separate Windows images for all of our target WS variants and can simply build one without that extra metadata.

@rbtr
Copy link
Contributor Author

rbtr commented Dec 13, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr requested a review from jpayne3506 December 13, 2024 23:54
@rbtr rbtr self-assigned this Dec 13, 2024
@rbtr rbtr added cns Related to CNS. npm Related to NPM. cni Related to CNI. dependencies Dependencies only. windows release/1.5 Change affects v1.5 release train labels Dec 13, 2024
@rbtr rbtr enabled auto-merge December 13, 2024 23:55
thatmattlong
thatmattlong previously approved these changes Dec 16, 2024
jpayne3506
jpayne3506 previously approved these changes Dec 16, 2024
@rbtr rbtr force-pushed the backport/v1.5/win-hpc branch from 5bc83dd to db57913 Compare December 16, 2024 22:14
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Dec 31, 2024
@rbtr rbtr force-pushed the backport/v1.5/win-hpc branch from db57913 to e42b448 Compare January 3, 2025 18:34
@rbtr
Copy link
Contributor Author

rbtr commented Jan 3, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions github-actions bot removed the stale Stale due to inactivity. label Jan 4, 2025
@github-actions github-actions bot removed the stale Stale due to inactivity. label Feb 13, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Feb 27, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Feb 27, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 14, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Mar 14, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Mar 29, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Mar 30, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 14, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Apr 17, 2025
Copy link

github-actions bot commented May 2, 2025

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 2, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label May 2, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 17, 2025
Copy link

Pull request closed due to inactivity.

@github-actions github-actions bot closed this May 25, 2025
auto-merge was automatically disabled May 25, 2025 00:01

Pull request was closed

@github-actions github-actions bot deleted the backport/v1.5/win-hpc branch May 25, 2025 00:01
@rbtr rbtr added exempt-stale Keep this fresh and removed stale Stale due to inactivity. labels May 29, 2025
@rbtr rbtr restored the backport/v1.5/win-hpc branch May 29, 2025 22:52
@rbtr rbtr reopened this May 29, 2025
Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Jun 13, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cni Related to CNI. cns Related to CNS. dependencies Dependencies only. exempt-stale Keep this fresh npm Related to NPM. release/1.5 Change affects v1.5 release train windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants